C# xUnit test actual values returned are empty

Question

I'm trying to write unit test using xUnit for EntityService class which is using Dapper to get data from Sqllite database. In my unit test it always returns actual values as List [] and test fails. I'm not understanding what I am missing here.

Test Class

public class EntityServiceTests
{
    private readonly IEntityService _sut;
    private readonly Mock _entityServiceMock;

    public EntityServiceTests()
    {
        _entityServiceMock = new Mock();

        var dapperMock = new Mock();
        _sut = new EntityService(dapperMock.Object);
    }

    [Fact]
    public void GetEntities_ShouldReturnEntities()
    {
        //Arrange
        var expectedEntities = new List
        {
            new()
            {
                Id = 1,
                Name = "Test",
                X = 12,
                Y = 14.5,
                CoordId = 1
            },
            new()
            {
                Id = 2,
                Name = "Test2",
                X = 16,
                Y = 18.5,
                CoordId = 2
            }
        };

        var query = @"SELECT ent.*, crd.x, crd.y, crd.id as CoordId 
                            FROM entities ent 
                            INNER JOIN coords crd ON crd.entityId = ent.Id";

        _entityServiceMock.Setup(x => x.GetEntities(0)).Returns(expectedEntities);

        //Act
        var entities = _sut.GetEntities(0).ToList();

        //Assert

        Assert.Equal(expectedEntities, entities);
    }
}

Service Class

public class EntityService : IEntityService
{
    private readonly IDapperWrapper _dapperWrapper;

    public EntityService(IDapperWrapper dapperWrapper)
    {
        _dapperWrapper = dapperWrapper;
    }

    public IEnumerable GetEntities(int entityId)
    {
        var query = @"SELECT ent.*, crd.x, crd.y, crd.id as CoordId 
                            FROM entities ent 
                            INNER JOIN coords crd ON crd.entityId = ent.Id ";
        if (entityId > 0)
        {
            query += " WHERE ent.id = @id";

            var entities = _dapperWrapper.Query(query, new { id = entityId });
            return entities;
        }
        else
        {
            var entities = _dapperWrapper.Query(query);

            return entities;
        }
    }
}

Dapper Wrapper Class

public class DapperWrapper : IDapperWrapper
{
    private IDbConnection Connection { get; }

    public DapperWrapper()
    {
        Connection = new SQLiteConnection(GetConnectionString("ConnectionString"));
    }

    private string GetConnectionString(string name)
    {
        return ConfigurationManager.ConnectionStrings[name].ConnectionString;
    }

    public IEnumerable Query(string query)
    {
        return Connection.Query(query);
    }

    public IEnumerable Query(string query, object param)
    {
        return Connection.Query(query, param);
    }

    public T QuerySingle(string query, object param)
    {
        return Connection.QuerySingle(query, param);
    }
}

Normally the project is working fine. but in Test it fails. I think i'm missing something very basic but crucial.

UPDATE: I'm using this code now but still getting failed result

    [Fact]
    public void GetEntities_Should_Return_All_Entities_If_0_Is_Provided_In_Param()
    {
        //Arrange
        var expectedEntities = new List
        {
            new()
            {
                Id = 1,
                Name = "Test",
                X = 12,
                Y = 14.5,
                CoordId = 1
            },
            new()
            {
                Id = 2,
                Name = "Test2",
                X = 16,
                Y = 18.5,
                CoordId = 2
            }
        };

        var query = @"SELECT ent.*, crd.x, crd.y, crd.id as CoordId 
                        FROM entities ent 
                        INNER JOIN coords crd ON crd.entityId = ent.Id ";

        var dapperMock = new Mock();
        dapperMock.Setup(x => x.Query(query)).Returns(expectedEntities);
        var sut = new EntityService(dapperMock.Object);

        //Act
        var entities = sut.GetEntities(0);

        //Assert
        Assert.Equal(expectedEntities, entities);
    }

user_4919526 · Answer

I think i'm missing something very basic but crucial.

Indeed mocking is intended to be used to mock away the dependencies from a unit to test (sut). In your case your unit to test is the EntityService and the dependency to mock away is IDapperWrapper.
But instead of only mocking the dependency, you're mocking the SUT as well with _entityServiceMock.

So you COULD try to do it like this within your test:

public class EntityServiceTests
{
    [Fact]
    public void GetEntities_ShouldReturnEntities()
    {
        //Arrange
        var expectedEntities = new List
        {
            new()
            {
                Id = 1,
                Name = "Test",
                X = 12,
                Y = 14.5,
                CoordId = 1
            }
        };

        var query = @"SELECT ent.*, crd.x, crd.y, crd.id as CoordId 
                            FROM entities ent 
                            INNER JOIN coords crd ON crd.entityId = ent.Id WHERE ent.id = @id";
        var dapperMock = new Mock();
        dapperMock.Setup(x => x.Query(query, 1)).Returns(expectedEntities.First());
        var sut = new EntityService(dapperMock.Object);

        //Act
        var entities = sut.GetEntities(1).ToList();

        //Assert
        Assert.Equal(expectedEntities, entities);
    }
}

But I highly discourage you from doing so because you'll end up mocking all the Dapper stuff.

Instead you better use an in-memory database (like SQLite), use a real Dapper instance. This way your tests will become much more comprehensive, shorter and business-facing. This blog post should give you a good starting point.

C# xUnit test actual values returned are empty

1 Answers