GitHub actions not blocking PR with required step in skipped state

user_16994680 0
Viewed 356

I have the GitHub action that should only be ran when the commit message contains 'test_api'. However, I do want it to be a required check for the PR to be able to get merged. For some reason this is not picked up, and it does not make any sense to me.

jobs:
  api-tests:
    if: contains(github.event.commits[0].message, '[test_api]')
    runs-on: ubuntu-latest
    ...

PR ready to merge

Branch protection

github-actions github
2 Answers

It says that tests were skipped - that means this is not true:

if: contains(github.event.commits[0].message, '[test_api]')

Unless you have more actions in the workflow.

user_20678770

I would force a failure if the condition isn't true.

jobs:
  api-tests:
    if: contains(github.event.commits[0].message, '[test_api]')
    runs-on: ubuntu-latest
    steps:
      ...
    
  not-api-tests:
    if: "!contains(github.event.commits[0].message, '[test_api]')"
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2.3.4
    - name: Fail the job
      run: exit 1

Note: This should work on all 3 platforms (ubuntu, macos, windows).

I tested it here (committing with [test_api]) and here (forcing the error with another commit message). The workflow implementation can be found here.

user_84964620
Related