Refactor method and remove extra local variable(remove binding)

user_11926338 0
Viewed 113

I have this class:

public class User {
    private String name;
    private int age;
    //getters setters
}

I have a method, which updates a user object:

public void foo(User user) { 
    boolean needUpdate = false;
    
    if(needUpdateName(user.getName())) {
        user.setName("new name"); 
        needUpdate = true;
    }
    
    if(needUpdateAge(user.getAge())) {
        user.setAge(42);
        needUpdate = true; 
    }
    
    if(needUpdate) {
        userRepository.update(user);
    } 
}

It's a simple example, only as an example. How can I refactor this code and remove needUpdate variable?

refactoring methods java
1 Answers

Just split Foo to two methods

public void updateNameIfNeed(User user) {
    if (needUpdateName(user.getName())) {
       user.setName("new name"); 
       userRepository.update(user);
    }
}

public void updateAgeIfNeed(User user) {
    if (needUpdateAge(user.getAge())) {
        user.setAge(42);
        userRepository.update(user);
    }
}
user_54854540
Related