How do I modify this code to sort list using keyword argument?

user_17685776 0
Viewed 179

Python’s list method sort includes the keyword argument reverse, whose default value is False. The programmer can override this value to sort a list in descending order.

Modify the selectionSort function discussed in this chapter so that it allows the programmer to supply this additional argument (as the second parameter) to redirect the sort.

This is what I have so far:

def selectionSort(lyst,reverse):
    """Sorts the items in lyst in ascending order."""
    i = 0
    while i < len(lyst) - 1: # Do n – 1 searches
        minIndex = i # for the smallest item
        j = i + 1
        while j < len(lyst): # Start a search
            if lyst[j] < lyst[minIndex]:
                minIndex = j
            j += 1
        if minIndex != i: # Swap if necessary
            swap(lyst, minIndex, i)
        i += 1

def swap(lyst, x, y):
    """Exchanges the elements at positions x and y."""
    lyst[x], lyst[y] = lyst[y], lyst[x]
        
def main():
    """Tests with four lists."""
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst)
    print(lyst)
    lyst = list(range(6))
    selectionSort(lyst)
    print(lyst)
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst, reverse = True)
    print(lyst)
    lyst = list(range(6))
    selectionSort(lyst, reverse = True)
    print(lyst)

if __name__ == "__main__":
    main()
python
3 Answers

The first issue is you have defined a second parameter to your function. This will cause your current tests to fail. To fix this, you can set a default to False to keep your existing behavior working.

Check out default arguments

Then based on the flag you can perform different logic. See the code notes below, we add a check to see if reverse is True or False. if default or set to False we will do normal order. if True, we will do your current logic backwards, using max instead of min.

def selectionSort(lyst,reverse=False):
    """Sorts the items in lyst in ascending order."""
    if not reverse:
        # do your old code
        i = 0
        while i < len(lyst) - 1: # Do n – 1 searches
            minIndex = i # for the smallest item
            j = i + 1
            while j < len(lyst): # Start a search
                if lyst[j] < lyst[minIndex]:
                    minIndex = j
                j += 1
            if minIndex != i: # Swap if necessary
                swap(lyst, minIndex, i)
            i += 1
    if reverse:
        # reverse your code
        i = 0
        while i < len(lyst) - 1: # Do n – 1 searches
            maxIndex = i # for the largest item
            j = i + 1
            while j < len(lyst): # Start a search
                if lyst[j] > lyst[maxIndex]:
                    maxIndex = j
                j += 1
            if maxIndex != i: # Swap if necessary
                swap(lyst, maxIndex, i)
            i += 1

def swap(lyst, x, y):
    """Exchanges the elements at positions x and y."""
    lyst[x], lyst[y] = lyst[y], lyst[x]
        
def main():
    """Tests with four lists."""
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst)
    print(lyst)
    # test with trues
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst, True)
    print(lyst)
    lyst = list(range(6))
    selectionSort(lyst)
    print(lyst)
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst, reverse = True)
    print(lyst)
    lyst = list(range(6))
    selectionSort(lyst, reverse = True)
    print(lyst)

if __name__ == "__main__":
    main()

Now that the difference in the parameter is explained, you could further improve your code based on the single operation being changed:

i = 0
while i < len(lyst) - 1: # Do n – 1 searches
    index = i # for the item
    j = i + 1
    while j < len(lyst): # Start a search
        if not reverse:
          if lyst[j] < lyst[index]:
              index = j
        else:
          if lyst[j] > lyst[index]:
              index = j
        j += 1
    if index != i: # Swap if necessary
        swap(lyst, index, i)
    i += 1
user_83820670

Slightly shorter selectionSort, fix the issue with the parameter

def selectionSort(lyst, reverse=False):
    """Sorts the items in lyst in ascending order."""
    for i in range(len(lyst)):
        si = i
        for j in range(i + 1, len(lyst)):
            if reverse:
                if lyst[j] > lyst[si]:
                    si = j
            else:
                if lyst[j] < lyst[si]:
                    si = j
        lyst[i], lyst[si] = lyst[si], lyst[i]


def swap(lyst, x, y):
    """Exchanges the elements at positions x and y."""
    lyst[x], lyst[y] = lyst[y], lyst[x]


def main():
    """Tests with four lists."""
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst, reverse=True)
    print("lyst0", lyst)
    lyst = list(range(6))
    selectionSort(lyst, reverse=False)
    print("lyst1", lyst)
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst, reverse=True)
    print("lyst2", lyst)
    lyst = list(range(6))
    selectionSort(lyst, reverse=False)
    print("lyst3", lyst)


if __name__ == "__main__":
    main()

Prints

lyst0 [5, 4, 3, 2, 1, 0]
lyst1 [0, 1, 2, 3, 4, 5]
lyst2 [5, 4, 3, 2, 1, 0]
lyst3 [0, 1, 2, 3, 4, 5]
user_39316650

You could define your comparison as a lambda function with its behavior determined by a keyword conditional argument.

def selectionSort(lyst,reverse=False):
    """Sorts the items in lyst in ascending order."""
    i = 0

    if reverse: bool_func = lambda v1, v2 : v1 < v2
    else: bool_func = lambda v1, v2 : v1 > v2

    while i < len(lyst) - 1: # Do n – 1 searches
        minIndex = i # for the smallest item
        j = i + 1
        while j < len(lyst): # Start a search
            if bool_func(lyst[j], lyst[minIndex]):
                minIndex = j
            j += 1
        if minIndex != i: # Swap if necessary
            swap(lyst, minIndex, i)
        i += 1

def swap(lyst, x, y):
    """Exchanges the elements at positions x and y."""
    lyst[x], lyst[y] = lyst[y], lyst[x]
        
def main():
    """Tests with four lists."""
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst)
    print(lyst)
    lyst = list(range(6))
    selectionSort(lyst)
    print(lyst)
    lyst = [2, 4, 3, 0, 1, 5]
    selectionSort(lyst, reverse = True)
    print(lyst)
    lyst = list(range(6))
    selectionSort(lyst, reverse = True)
    print(lyst)

if __name__ == "__main__":
    main()

Outputs:

[5, 4, 3, 2, 1, 0]
[5, 4, 3, 2, 1, 0]
[0, 1, 2, 3, 4, 5]
[0, 1, 2, 3, 4, 5]
user_164501690
Related