Adding an early return to avoid using else and additional nesting

user_16480115 0
Viewed 37

I got the below comment from a developer: " add an early return here to avoid using else and additional nesting". But I have a bit of difficulty with modifying.

Can you please let me know what exactly should I do in this case? Thank you!

failOnStatusCode: false,

    }).then((res) => {


      // Assertion for one by one

      if (res.status != 200) {

        cy.log(JSON.stringify(res));

      } else {

        expect(res.body.id).to.eq(vehicleIdBuyNow);

        expect(res.body.auctionStatus).contains("finished");

        expect(res.body.price).to.be.equal(minPrice);

        expect(res.body.winningBidPlatformId).contains(platformIdBuyNow);

        expect(true).to.be.true;
cypress node.js if-statement javascript
1 Answers

The recommendation is to change it to:

.then((res) => {
    if (res.status != 200) {
        cy.log(JSON.stringify(res));
        return; // exit function, no need for an `else` after this
    }
    expect(res.body.id).to.eq(vehicleIdBuyNow);
    expect(res.body.auctionStatus).contains("finished");
    expect(res.body.price).to.be.equal(minPrice);
    expect(res.body.winningBidPlatformId).contains(platformIdBuyNow);
    expect(true).to.be.true;
user_95152070
Related