Android: Compose navigation arguments are not being passed

Viewed 765

I have a very simple application ui made with Compose.

3 screens for now: login, items list and item details.

The problem is when i click on an item in the items list, i navigate to the item details and i pass the item ID as nav arg.

The problem is, I can't retrieve it and the arguments bundle is empty.

Here is my code:

MainActivity:

@AndroidEntryPoint
class MainActivity : ComponentActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            AdrestoApplication()
        }
    }
}

Main Composable:

@Composable
fun AdrestoApplication() {
    val authViewModel = hiltViewModel<AuthViewModel>()

    val navController = rememberNavController()
    val navBackStackEntry by navController.currentBackStackEntryAsState()
    val isLoggedIn = authViewModel.isLoggedIn()
    val initialRoute =
        if (isLoggedIn) Destinations.LISTINGS_LIST else Destinations.LOGIN_ROUTE
    val currentRoute = navBackStackEntry?.destination?.route ?: initialRoute

    AdrestoTheme {
        NavGraph(
            navController = navController,
            startDestination = currentRoute,
        )
    }
}

NavGraph:

object Destinations {
    const val LOGIN_ROUTE = "login"
    const val HOME_ROUTE = "home"
    const val ORDER_DETAILS = "order_details"
    const val ORDERS_LIST = "orders_list"
    const val LISTING_DETAILS = "listing_details/{listingId}"
    const val LISTINGS_LIST = "listings_list"
}

@Composable
fun NavGraph(
    navController: NavHostController = rememberNavController(),
    startDestination: String = Destinations.LOGIN_ROUTE,
) {
    NavHost(navController = navController, startDestination = startDestination) {
        composable(Destinations.LOGIN_ROUTE) {
            Login(
                navController = navController,
            )
        }
        composable(Destinations.LISTINGS_LIST) {
            ListingsScreen(
                navController = navController,
            )
        }
        composable(
            Destinations.LISTING_DETAILS,
            arguments = listOf(navArgument("listingId") { type = NavType.LongType })
        ) {
            Log.d("Navhost","NavGraph: the nav arg found is: ${it.arguments!!.getLong("listingId")}") // logs 0
            ListingScreen(
                navController = navController,
                listingId = it.arguments!!.getLong("listingId"),
            )
        }
    }
}

The part of the UI that triggers the navigation with argument:

LazyColumn(
    modifier = Modifier
        .padding(all = 8.dp)
        .background(MaterialTheme.colors.background)
) {
    items(listings.value.data ?: listOf()) { listing ->
        Listing(
            listing = listing,
            onCardClick = {
                Log.d("some tag", "ListingsScreen: navigating to ${listing.id}") // logs as expected
                val route = "listing_details/${listing.id}"
                Log.d("some tag", "ListingsScreen: the route is $route") //logs listing_details/418 (for example)
                navController.navigate(route)
            },
        )
    }
}

I can't understand what's going wrong here, isn't the composables in the same navgraph?

I have another issue which is when i press the back button, the navigation don't go up but it closes the app (like if there is not backstack...).

1 Answers

The problem was in the start destination argument of the NavGraph, I was reinitializing (unkowingly) the navController backstack each time I navigated to a new screen.

@Composable
fun AdrestoApplication() {
    val authViewModel = hiltViewModel<AuthViewModel>()

    val navController = rememberNavController()
    val navBackStackEntry by navController.currentBackStackEntryAsState()
    val isLoggedIn = authViewModel.isLoggedIn()
    val initialRoute =
        if (isLoggedIn) Destinations.LISTINGS_LIST else Destinations.LOGIN_ROUTE
    val currentRoute = navBackStackEntry?.destination?.route ?: initialRoute

    AdrestoTheme {
        NavGraph(
            navController = navController,
            startDestination = currentRoute, // this was issue, changed to a static initial route.
        )
    }
}
Related