i want to figure out what's wrong in my code

user_14031667 0
Viewed 114

I want to make a java pattern like this using while loops

*  *  *  * 
*  *  * 
*  * 
*

and here is my code

int i = 4;
int j = 0;

while (i >= 0) {
    while (j < i) {
        System.out.print(" * ");
        j++;
    }
    
    System.out.print("\n");
    i--;
}

but its giving output like this:

*  *  *  *

Does anyone knows what to do....?

java
6 Answers

TRY CONSIDERING THIS ONE MIGHT HELP YOU !!

Using FOR Loop

public class DownwardTrianglePattern {  
    public static void main(String[] args) {  
        int rows = 4;      
        //outer loop  
        for (int i = rows-1; i >= 0 ; i--) {  
            //inner loop  
            for (int j = 0; j <= i; j++) {  
                //prints star and space  
                System.out.print("*" + " ");  
            }  
            //throws the cursor in the next line after printing each line  
            System.out.println();  
       }  
    }  
}

Using While Loop

public class Itriangle {
    public static void main(String[] args) {
        Scanner sc = new Scanner(System.in);
        System.out.println("Enter N : ");
        int n = sc.nextInt(); 
        System.out.print("Enter Symbol : ");
        char c = sc.next().charAt(0);
        int i = n, j;
        while(i > 0) {
            j = 0;
            while(j++ < i) {
                System.out.print(c);
            }
            System.out.println();
            i--;
        } 
    }
}
user_138584440

After i--; you can j=0;

The problem in your code is that in first iteration after completing both the while loops the value of variables is i=3 and j=4. So for the next iteration the first while loop will run as the condition is true i.e. 3>=0 but for the next while loop the condition will be false as j i.e. 3 not less than i i.e. 3. So that's why the next loop does not executes and you are getting that output.

user_157444190

when you're finished with inner loop you have to reset j value else it's value will remain 4 which is not less then i value. you can reset the value before starting inner while

int i = 4;
int j = 0;

while (i >= 0) {
    j = 0;
    while (j < i) {
        System.out.print(" * ");
        j++;
    }
    
    System.out.println(""); // println will work same as System.out.print("\n") in this scenario
    i--;
}
user_104292590

The j needs to be initialized inside loop.

I changed the code as below. it's giving correct output

   int i = 4;
        while (i >= 0) {
            int j = 0;
            while (j < i) {
                System.out.print(" * ");
                j++;
            }

            System.out.print("\n");
            i--;
        }
user_62551910

please reset j after j loop

    int i = 4;
    int j = 0;

    while (i >= 0) {
        while (j < i) {
            System.out.print(" * ");
            j++;
        }
        j = 0;

        System.out.print("\n");
        i--;
    }
user_115614130

By the way your problem can be nicely solved using recursion

public static void main(String[] args) {
    printLine(4);
}

private static void printLine(int numberOfStars) {
    if(numberOfStars == 0) {
        return;
    }

    System.out.println("* ".repeat(numberOfStars));

    printLine(numberOfStars - 1);
}

Output

*  *  *  *  
*  *  *  
*  *  
*
user_157773700
Related