Trigger could not be executed due to table mutating

Question

I want to know what is the problem for this issue whereby it kept on showing me this error when I execute my stored procedure. My goal is to before updating data into my table using my stored procedure, I want to check errors from trigger that the user input

SQL> exec PRC_PAY_TRIP(1031,2031,'Cash',200)
BEGIN PRC_PAY_TRIP(1031,2031,'Cash',200); END;

*
ERROR at line 1:
ORA-04091: table TEST.PAYMENT is mutating, trigger/function may not see it
ORA-06512: at "TEST.TRG_PAYMENT_VALIDATION", line 10
ORA-04088: error during execution of trigger 'TEST.TRG_PAYMENT_VALIDATION'
ORA-06512: at "TEST.PRC_PAY_TRIP", line 45
ORA-06512: at line 1

I went to search the problem and one of the solution was simply change 'after' to 'before' within the trigger

"before update on payment" --> like this

but it still wouldn't work

STORED PROCEDURE

CREATE OR REPLACE PROCEDURE PRC_PAY_TRIP(CUST_ID IN NUMBER,PAYMENT_ID IN NUMBER,PAYMENT_TYPE IN VARCHAR2,AMT_PAY IN NUMBER)AS


v_paymentstatus VARCHAR2(15) := 'Paid';
v_temppaymentid NUMBER(4) := PAYMENT_ID;
v_truenumber NUMBER(10);


no_null_on_custID EXCEPTION;
no_null_on_payID EXCEPTION;
invalid_paymentid EXCEPTION;
invalid_paymenttype EXCEPTION;
invalid_paymentamt EXCEPTION;


BEGIN

v_truenumber := v_temppaymentid-1000;


IF CUST_ID < 0
THEN
RAISE no_null_on_custID;
END IF;

IF PAYMENT_ID < 0
THEN
RAISE no_null_on_payID;
END IF;

IF CUST_ID ^= v_truenumber THEN
RAISE invalid_paymentid;
END IF;

IF PAYMENT_TYPE ^= 'Cash' AND PAYMENT_TYPE ^= 'E-Wallet' THEN
RAISE invalid_paymenttype;
END IF;

IF AMT_PAY < 0 THEN
RAISE invalid_paymentamt;
END IF;



UPDATE Payment
SET paymenttype = PAYMENT_TYPE,paymentdate = TO_CHAR(sysdate,'DD/MON/YYYY'), paymentstatus = v_paymentstatus
where paymentid = PAYMENT_ID;


EXCEPTION

WHEN no_null_on_custID then
DBMS_OUTPUT.PUT_LINE('Invalid Customer ID');

WHEN no_null_on_payID then
DBMS_OUTPUT.PUT_LINE('Invalid Payment ID');

WHEN invalid_paymenttype then
DBMS_OUTPUT.PUT_LINE('You can either choose Cash or E-Wallet only!');

WHEN invalid_paymentid then
DBMS_OUTPUT.PUT_LINE('Payment id is not yours, just add 1000 from your Customer ID and that will be your Payment ID');

WHEN invalid_paymentamt then
DBMS_OUTPUT.PUT_LINE('Amount pay cannot be negative value!');

END;
/

TRIGGER

CREATE OR REPLACE trigger trg_payment_validation
 before update on payment
 for each row

DECLARE

 v_paymentstatus payment.paymentstatus%type;
 v_customerid booking.customerid%type;
 v_paymentid payment.paymentid%type;
 v_paymentamt payment.paymentamount%type;

BEGIN 

select po.paymentstatus into v_paymentstatus
 from payment po
 where po.paymentid = :new.paymentid;


select po.paymentamount into v_paymentamt
 from payment po
where po.paymentid = :new.paymentid;

if SQL%FOUND then
    if v_paymentstatus = 'Paid' then
      RAISE_APPLICATION_ERROR(
        -20950,
        'You already paid for your trip, have a nice day'
      );
    elsif v_paymentamt < :old.paymentamount then
      RAISE_APPLICATION_ERROR(
        -20950,
        'Insufficient amount entered, pls pay the exact amount'
      );
    end if;
  end if;
EXCEPTION
  WHEN NO_DATA_FOUND THEN
    NULL;
END;
/

user_1509264 · Answer

If you are checking data in the same row as you are updating then don't use a SELECT statement, instead check the :NEW and :OLD bind variables:

CREATE OR REPLACE trigger trg_payment_validation
  before update on payment
  for each row
BEGIN 
  if :OLD.paymentstatus = 'Paid' then
    RAISE_APPLICATION_ERROR(
      -20950,
      'You already paid for your trip, have a nice day'
    );
  elsif :NEW.paymentamount < :old.paymentamount then
    RAISE_APPLICATION_ERROR(
      -20950,
      'Insufficient amount entered, pls pay the exact amount'
    );
  end if;
END;
/

Trigger could not be executed due to table mutating

1 Answers