Why I need to click twice to generate a value in input field

user_9976753 0
Viewed 221

I developed a page using codeigniter framework. Following is the part of a code in the controller. This creates few sets of buttons and input fields. When I click on each button values should added to the relevant input field. Everything works fine. But the problem is I have to click twice on the button. Once I click twice then values start to appear. And if I continue to click on other buttons then values generated in relavent input fields by one click. It need double click for the first button click. (Not for the first button of the order. I need to click twice for even start with button in the middle).

Also if I click two different buttons(each button 1 time). Then values will be added to the both input fields with the second click.

Also according to direction in a previous answer of the stackoverflow question I tried changing it to

$test .= '<input type="button"

instead of

$test .= '<button

But there was no luck. I'm really thankful if someone can give me a clue for this issue.

foreach ($data as $c) {
  foreach ($c as $value) {
    
    //There are some codes here 
    //But there are no <form> elements in this area.

    $test .= "&emsp;&emsp;<a>reply</a><br>";
    $test .= '<input type="text" id="new_reply' . $value['id'] . '"  class="form-control">';
    $test .= '<button data-comment-id="' . $value['id'] . '" onclick="test_function(this);">Reply</button>';

  }
}

echo json_encode($test);

And here is my js function. Please note that this is not the end purpose of this function. I changed it to something very simple to identify the issue. Also to convey my issue.

$(document).ready(function(){
    test_function();
})


function test_function(reply){
  $("button").click(function() {
        var comment_id = reply.getAttribute("data-comment-id");
        if(comment_id){
            var inputbox_id = "new_reply" + comment_id;
            document.getElementById(inputbox_id).value ='test value';
        }
  });

}

and here is a sample image of the page enter image description here

Edit 1

In my view file I have code like this.

<div id="page_content" class="text-dark"></div>

then using ajax method I add the content like this

$('#page_content').html(response);

So I noticed that actually the div element is only clicked when I click the button.

I used these function to test this

$(document).ready(function(){
    Insert_record();
    view_content();
    insert_reply(this);
})

function insert_reply(reply){
$("div").click(function() {
    console.log("USA");
    $("button").click(function() {
        //insert_reply(this);
        console.log("Argentina");
    });
});
}

When I click a button once then result was this.

enter image description here

When I click for the second time then console changed to this.

enter image description here

codeigniter php jquery ajax javascript
2 Answers

The jQuery function $.click() binds an event listener to the button, but it only does so after test_function() has already been called from the onclick attribute.

Your first button click attaches the listener. The second click actually triggers it. You probably want to attach the event listener within $(document).ready instead, that way they will be attached to your buttons as soon as they are ready:

$( document ).ready(function() {
  // attach event listeners here
});
user_82127380

I couldn't understand this $("button").click(function() {, because you are calling test_function() on click itself so why you need a check again? here you can understand the difference.

This need to be a simple function call on click right?

function test_function(reply){
        console.log("hello");
        var comment_id = reply.getAttribute("data-comment-id");
        if(comment_id){
            var inputbox_id = "new_reply" + comment_id;
            console.log(comment_id);
            document.getElementById(inputbox_id).value ='test value';
        }
}
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<a>reply</a><br>
  <input type="text" id="new_reply1234"  class="form-control">
<button data-comment-id="1234" onclick="test_function(this);">Reply</button>

Sorry if this answer is irrelevant, but this is what I could understand from the information you have given.

user_155235910
Related