Can't get each to work after ajax page load changes contents

user_1741251 0
Viewed 29

on page load I run this function to hide long quoted posts into a clickable link to prevent huge comments on my site:

function hide_long_quotes()
{
    $('.comments .comment_quote').each(function(i) 
    {
        var actual_text = $(this).text();
        var content = $(this).outerHTML();

        if(actual_text.length > showChar) 
        {
            var cite = $(this).find('cite span.username').first().text();
            var cite_link = '';

            if (cite.length > 0)
            {
                cite_link = 'from ' + cite;
            }

            var html = '<span class="morecontent">' + content + '</span><a href="" class="morelink">' + moretext + cite_link + '</a><br />';

            $(this).replaceWith(html);
        }
        if (i+1 === quote_count) // this will be executed at the end of the loop
        {
            // deal with being linked to a comment, so we can put the window to the correct scroll position, since it will be different due to hidden quotes making the page smaller
            if(window.location.hash) 
            {
                var hash = window.location.hash.substring(1); //Puts hash in variable, and removes the # character
                if (hash.indexOf("r") >= 0)
                {
                    $('#'+hash)[0].scrollIntoView();
                }
            }
        }
    });
}

The problem is that when I reload ".comments" through ajax/load the above function no longer works:

function paginate_comments(page, article_id)
{
    var url = "/includes/ajax/post_comment.php";
    var current_url = window.location.href;
    var host = window.location.host;
    
    if(current_url.indexOf(host + '/admin.php?module=reviewqueue') != -1 || current_url.indexOf(host + '/admin.php?module=articles&view=Submitted') != -1 || current_url.indexOf(host + '/admin.php?module=articles&view=Submitted') != -1)
    {
        var area = 'admin';
    }
    else
    {
        var area = 'normal';
    }
    
    $('.comments').load(url, {'type':'reload', 'article_id': article_id, 'page': page, 'area': area}, function()
    {
        $(".lb-container").show();
        $('.box.comments').get(0).scrollIntoView();
        hide_long_quotes();
    });
}

Not sure why it doesn't work, as the function is being called in the completed callback part of the load function?

jquery ajax javascript
1 Answers

What about giving the element collection to that function:

function hide_long_quotes(var comments = false)
{               /* for the case that you don't pass a collection to the function, maybe in the first call when the page is loaded */
    comments = comments ? comments : $('.comments .comment_quote');
    
    comments.each(function(i) 
    {
...
}

function paginate_comments(page, article_id)
{
...
    $('.comments').load(
        url, 
        {
            'type':'reload', 
            'article_id': article_id, 
            'page': page, 
            'area': area
        }, 
        function() 
        {
            $(".lb-container").show();
            $('.box.comments').get(0).scrollIntoView();
            hide_long_quotes($('.comments .comment_quote'));
        }
    );
}
user_153773550
Related