How to get mypy to recognize login_required decorator?

user_2034128 0
Viewed 453

I have the following Django view:

@login_required
def view(request: HttpRequest) -> HttpResponse:
    if not request.user.some_attribute:
        return redirect("somewhere")
    return render(request, "template_name")

and a custom User model that has an attribute some_attribute.

I use mypy to enforce type checking, with this mypy.ini:

[mypy]
ignore_missing_imports = True
plugins = mypy_django_plugin.main

[mypy.plugins.django-stubs]
django_settings_module = [PROJECT NAME].settings

However, mypy errors with the following:

Item "AnonymousUser" of "Union[User, AnonymousUser]" has no attribute "some_attribute"

which makes sense because an anonymous user wouldn't have that attribute, but I have a login_required decorator, making AnonymousUsers impossible (it would be a User).

How do I tell mypy to ignore this, without using # type: ignore?

mypy django python
2 Answers

You can also subclass the HttpRequest and explicitly set the user field on your subclass to have the type explicitly defined as User instead of the default union pair, like so:

from django.http import HttpRequest
from my_user_app.models import MyUser

class AuthenticatedHttpRequest(HttpRequest):
    user: MyUser

Then, every time you want to use the login_required decorator, set the type hint of the request argument to your subclass (in this case it would be AuthenticatedHttpRequest) like so:

@login_required
def view(request: AuthenticatedHttpRequest) -> HttpResponse:
    if not request.user.some_attribute:
        return redirect("somewhere")
    return render(request, "template_name")

This method is specified as a recommended one in django-stubs readme file, which apparently you're using to source the Django skeletons for mypy.

user_17832370

I believe casting request.user to the required type should work:

from typing import cast

@login_required
def view(request: HttpRequest) -> HttpResponse:
    request.user = cast(User, request.user)
    if not request.user.some_attribute:
        return redirect("somewhere")
    return render(request, "template_name")
user_106254200
Related