try catch not working in Node socket.io listener

user_14045896 0
Viewed 2597

I am working on an app that involves the use of WebSockets. I have the following code as a part of the application:

io.on('connection', socket => {

   let PLAYER = {};

   // Listener for event 1
   // Listener for event 2
   // ...

   socket.on('setName', ({name, role, room}) => {

        PLAYER.name = name;
        PLAYER.role = role;
        PLAYER.room = room;

        try{
            joinRoom(PLAYER);  // This function can throw an error
            socket.emit('roomJoin');
        }catch(e){
            socket.emit('error', e.message);
            return;
        }
    });
});

Now, when the joinRoom function does throw an error, Node just crashes with the following exception:

events.js:306
    throw err; // Unhandled 'error' event
    ^

Error [ERR_UNHANDLED_ERROR]: Unhandled error. ('error message')

The error event is never emitted. What has made the try catch block fail?

Note: I am using TypeScript, but have removed type declarations in the above snippet as they shouldn't have anything to do with the problem.

Edit 1:

I have recreated the issue with simpler code as follows:

import express from 'express';
import socketio from 'socket.io';
import http from 'http';

const PORT = process.env.PORT || 8000;

const app = express();
const server = http.createServer(app);
const io = socketio(server);

server.listen(PORT, () => {
    console.log(`Listening on port ${PORT}`);
});

const checkLength = (bar) => {
    if(bar.length > 14){
        throw Error('word is too long!');
    }
    // ...
}

io.on('connection', socket => {
    console.log('new socket connection');

    socket.on('foo', ({bar}) => {
        try{
            checkLength(bar);
        }catch(e){
            socket.emit('error', e.message);
            return;
        }
        console.log('app did not crash!');
    });
}

When the length of bar is greater than 14, the app crashes with the same error mentioned above.

typescript node.js websocket javascript
3 Answers

After replicating the server on my local machine, I realized you were calling emit on a reserved keyword for socket.io. When you call socket.emit('error', e.message), there is an expected listener to exist. One like this:

socket.on('error', err => {
  // An error occurred. 
})

You should use a different phrase for your emit. I personally use oops on my socket servers. socket.emit('oops', {error}). You can read more about error handling on their page.

To add, socket.emit('error') does not pass the error or any data down to the client and instead is handled by the server, which is why you need to use a different phrase.

user_8190400

You can use the promisses, and than you can profite from the then() method which also returns a Promise. It takes up to two arguments: callback functions for the success and failure cases of the Promise.

So your code should be something like this:

import express from 'express';
import socketio from 'socket.io';
import http from 'http';

const PORT = process.env.PORT || 8000;

const app = express();
const server = http.createServer(app);
const io = socketio(server);

server.listen(PORT, () => {
    console.log(`Listening on port ${PORT}`);
});

const checkLength = (bar) => {
  return new Promise((resolve, reject)=>{
    if(bar.length > 14){
      // throw Error('word is too long!');
      reject('word is too long!')
    } else {
      resolve('app did not crash!')
    }
  });  
}

io.on('connection', socket => {
  console.log('new socket connection');
  socket.on('foo', ({bar}) => {
    checkLength(bar).then((result) => {
        console.log('app did not crash!');
    }).catch(err => {
      console.log("app did crash with this error:", err);
    });
  });
}
user_29865690

I noticed you hadn't initialized your PLAYER variable.

let PLAYER = {};

#EDIT 1:

try also adding an error handler for your socket server and log it to get an idea of what is causing the error.

socket.on('error', (error) => {
  console.log(error);
});
user_77828820
Related