Throwing exception in initialisation list?

Admin 1
Viewed 77

I have the following code:

In Game.h:

mtm::Dimensions dimensions;
std::vector<std::shared_ptr<Character>> board;

In Game.cpp:

Game::Game(int height, int width) : dimensions(height, width), board(height * width, nullptr) 
{
    if (height <= 0 || width <= 0) {
        throw mtm::IllegalArgument();
    }
}

But as you may notice I'm throwing the error too late, if height * width is smaller than 0 then a bad_alloc will be thrown instead of IllegalArgument, How may I fix this?

Is there a way to throw an exception in the initialisation list?

methods class c++
3 Answers

If you cannot do the check in mtm::Dimensions, it really should be there, you can use a helper function:

int throw_if_not_positive(int x) {
    if (x <= 0) throw mtm::IllegalArgument();
    return x;
}

Game::Game(int height, int width) : 
    dimensions(throw_if_not_positive(height),
               throw_if_not_positive(width)), 
    board(height * width, nullptr) 
{
}

Or use unsigned, or use

struct positive_int {
     int value;
     positive_int(int x) : value(x) {
        if (x <= 0)  throw mtm::IllegalArgument();
     }
     operator int(){ return value; }
};

Game::Game(positive_int height, positive_int width) : 
    dimensions(height,width), 
    board(height * width, nullptr) 
{
}
user_41177280

You can first catch the bad_alloc thrown in the construction of board, and then throw your own custom exception:

Game::Game(int height, int width) try : dimensions(height, width), board(height * width, nullptr) 
{
    if (height <= 0 || width <= 0) {
        throw mtm::IllegalArgument();
    }
}
catch(...)  // or specifically bad_alloc
{
   throw mtm::IllegalArgument();  // or some other custom exception
}

Here's another (better) answer that's based on your own suggestion in the comments:

Game::Game(int height, int width) : 
  dimensions(height, width), 
  board((height * width > 0 ? height * width : throw mtm::IllegalArgument()), 
        nullptr) 
{
  // ...
}

Here's a demo.

user_83728530

Insert a helper function to validate the height and width.

size_t helper(int height, int width)
{
    if (height <= 0 || width <= 0) {
        throw mtm::IllegalArgument();
    }
    return height * width;
}

Game::Game(int height, int width) : 
    dimensions(height, width), 
    board(helper(height, width), nullptr) 
{
}
user_45813010
Related