I'm trying to inject DataSource from Tomcat 8.5.56 using the @Resource annotation, but when I run the code I get NullPointerException.
Note: Getting DataSource with InitialContext still works fine.
Resource definition in context.xml:
<?xml version="1.0" encoding="UTF-8"?>
<Context>
<Resource name="jdbc/postgres" auth="Container"
type="javax.sql.DataSource" driverClassName="org.postgresql.Driver"
url="jdbc:postgresql://localhost:5432/contact_directory"
username="username" password="password" maxTotal="20" maxIdle="10"
maxWaitMillis="-1"/>
</Context>
The servlet for testing:
@WebServlet(name = "TestController", urlPatterns = "/test")
public class TestController extends HttpServlet {
//this also doesn't work
//@Resource(lookup="java:/comp/env/jdbc/postgres")
@Resource(name="jdbc/postgres")
private DataSource dataSource;
@Override
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
String query = "SELECT ... FROM ..."; //here goes the query text
try(Connection connection= dataSource.getConnection();
Statement statement=connection.createStatement();
ResultSet resultSet= statement.executeQuery(query)) {
//some actions with resultSet
} catch (Exception e) {
e.printStackTrace();
}
}
}
Error code (the error line is Connection connection= dataSource.getConnection()):
java.lang.NullPointerException
at com.nevermind.controller.TestController.doGet(TestController.java:41)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:634)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:543)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81)
at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:690)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:615)
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:818)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1627)
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.base/java.lang.Thread.run(Thread.java:832)
Class with InitialContext that works fine:
public class DatabaseUtil {
public static DataSource getDataSource() {
DataSource ds=null;
try {
InitialContext cxt = new InitialContext();
ds = (DataSource) cxt.lookup( "java:/comp/env/jdbc/postgres" );
} catch (NamingException e) {
e.printStackTrace();
}
return ds;
}
}
Note: I've seen a lot of guides and similar questions, but no concrete solution.
Some answers have the similar solutions (Tomcat 7 Datasource injection mechanism), but in my case, it's still not working.
Someone said that Tomcat > 6 doesn't support @Resource annotation (Getting null pointer exception @Resource annotation in tomcat 7), but the next answer says that it supports.
I'm confused what may be the problem ?
