Why does this curl command fail when executed in groovy?

user_447424 0
Viewed 380

This curl command works in the terminal but fails in groovy. I added the err and out out from another question to try and understand why it fails. 

def initialSize = 4096
def out = new ByteArrayOutputStream(initialSize)
def err = new ByteArrayOutputStream(initialSize)
def process = "sh -c curl'https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts'".execute()
process.consumeProcessOutput(out, err)
process.waitFor()
println process.text
println err.toString()
println out.toString()

The output is "curl: try 'curl --help' or 'curl --manual' for more information"

curl groovy
1 Answers

Don't use string for execute, as Groovy will split on whitespace. You have to pass the "shell command" as a single argument to sh -c. So right now you a) lack a space between curl and the url and b) this will end up as two arguments (and you can not quote for that).

Use a string list instead:

['sh', '-c', "curl 'http://...'"].execute()

Also on a sidenote: if you just want the content of a url and don't need fancy things (timeouts, auth, ...), you can just as well do:

"https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts".toURL().text
user_31813920
Related