Is passing Object type as a method parameter always a sign of poor design?

user_2058534 0
Viewed 78

Assume I have the following enum

public enum EmailType {
    FORGET_PASSWORD, ACHIEVMENT_UNLOCK, WELCOME
}

and I have a function that generates email subjects based on the type (but it still requires dynamic data), e.g.

public String generateEmailSubject(EmailType emailType, Object obj) {
    String subject;
    switch(emailType) {
        case WELCOME:
            User user = (User) obj;
            subject = "Hello " + user.getFirstName();
        case FORGET_PASSWORD:
            User user = (User) obj;
            subject = "Forget password " + user.getEmail();
            break;
        case ACHIEVMENT_UNLOCK:
            Achievment achievment = (Achievment) obj;
            subject = "Achievment Unlock:" + achievment.getTitle();
            break;
    }

    return subject;
}

Is this bad practice? If so, what's a good design to handle this? Maybe a separate method for each EmailType but that could lead to a lot of methods and the subjects will not be centralized when I need to change them.

oop java
2 Answers

You could use polymorphism for this.

interface Subjectable {
    String getSubject();
}

class Achievement implements Subjectable {
    ...
    @Override
    public String getSubject() {
        return "Achievement unlocked: " + getTitle();
    }
}

class User implements Subjectable {
    ...
    @Override
    public String getSubject() {
        return "Forgot password: " + getEmail();
    }
}

Then you don't need to explicitly check the type of the object: you just call getSubject() on it.

user_38906320

As an alternative to khelwood's solution (in case, for example, you can't change the structure of User and Achievement), it may make sense to consider that the subject extraction operation really belongs with EmailType. If EmailType has the generateEmailSubject method, that would make a more cohesive unit instead of having the logic spread between it and whatever class currently defines generateEmailSubject().

public enum EmailType {

    FORGET_PASSWORD {
        @Override
        public String generateEmailSubject(Object obj) {
            User user = (User) obj;
            return "Forget password " + user.getEmail();
        }
    },

    ACHIEVMENT_UNLOCK {
        @Override
        public String generateEmailSubject(Object obj) {
            Achievment achievment = (Achievment) obj;
            return "Achievment Unlock:" + achievment.getTitle();
        }
    };

    public abstract String generateEmailSubject(Object obj);
}
user_57615580
Related