Unit test with Robolectric.buildAttributeSet() results in NullPointerException

user_703210 0
Viewed 1134

I've got a PercentView class, and I'm trying to set up a test where I want to verify it was drawn to the correct size. I've got this working for a simple bar, but now I want an image/icon above it, which is a drawable (vector actually).

Some notes about this:

  • I have a drawable file (which is vector) that is named app_enabled.xml, which is main\res\drawable\app_enabled.xml.
  • I'm using Robolectric 3.5.1
  • I've seen the code for the test the Robolectric team has here: Robolectric example: ViewStubTest.java

I've declared the stylable:

<declare-styleable name="PercentageView">
    <attr name="image" format="integer" />
</declare-styleable>

And the view:

public class PercentageView extends View {
    private int _activeColor;
    private int _barBackgroundColor;
    private float _barHeight;
    private Drawable _icon;
    private Paint _barBackgroundPaint;
    private Paint _barActivePaint;
    private int _percent;

    public PercentageView(Context context, @Nullable AttributeSet attrs, int defStyleAttr, int defStyleRes) {
        super(context, attrs, defStyleAttr, defStyleRes);
        TypedArray args = context.getTheme().obtainStyledAttributes(
                attrs,
                R.styleable.PercentageView,
                0,
                0);

        try {
            _icon = args.getDrawable(R.styleable.PercentageView_image);

        } finally {
            args.recycle();
        }

        init();
    }
}

And now the test:

@RunWith(RobolectricTestRunner.class)
public class PercentageViewTests {
    private ShadowCanvas _shadowCanvas;
    private int _width;
    private int _height;
    private float _expectedPercentWidth;
    private int _thePercent;
    private Canvas _canvas;

    private PercentageView SetUpView(int width, int height, int percent, boolean useIcon) {
        ShadowApplication app = shadowOf(RuntimeEnvironment.application);

        //Attempt to pass in the icon, if useIcon is true
        AttributeSet attr = useIcon ? Robolectric.buildAttributeSet()
            .addAttribute(R.styleable.PercentageView_image, "@drawable/app_enabled") //NullPointerException here
            .build() : null;

        PercentageView view = new PercentageView(app.getApplicationContext(), attr);
        view.setLayoutParams(new ViewGroup.LayoutParams(width, height));
        view.setPercent(percent);

        return view;
    }

    @Before
    public void setup() {
        Random random = new Random(10);
        _width = random.nextInt(100);
        random.setSeed(101);
        _height = random.nextInt(200);

        random = new Random(0);
        _thePercent = random.nextInt(100);
        _expectedPercentWidth = _width * _thePercent / 100;

        _canvas = new Canvas();
        _shadowCanvas = shadowOf(_canvas);
    }

    @Test
    public void ShouldHaveIcon() {
        PercentageView view = SetUpView(_width, _height, _thePercent, true);
        view.onDraw(_canvas);

        assertThat(_shadowCanvas.getRectPaintHistoryCount(), is(equalTo(3)));
    }
}

And the VERY sad, stack trace:

java.lang.NullPointerException
at org.robolectric.Robolectric$AttributeSetBuilder.addAttribute(Robolectric.java:161)
at myorg.controls.PercentageViewTests.SetUpView(PercentageViewTests.java:41)
at myorg.controls.PercentageViewTests.ShouldHaveIcon(PercentageViewTests.java:140)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:523)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.robolectric.internal.SandboxTestRunner$2.evaluate(SandboxTestRunner.java:226)
at org.robolectric.internal.SandboxTestRunner.runChild(SandboxTestRunner.java:108)
at org.robolectric.internal.SandboxTestRunner.runChild(SandboxTestRunner.java:35)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.robolectric.internal.SandboxTestRunner$1.evaluate(SandboxTestRunner.java:62)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.rt.execution.application.AppMainV2.main(AppMainV2.java:131)
robolectric junit4 android
2 Answers

Try replacing R.styleable.PercentageView_image with R.attr.image.

It seems the first argument to addAttribute() needs to be an attr res, rather than a stylable.

user_24790100

This is late to respond but, Today I struggled with this as well.

I wanted to create a custom HelpLinkButton that accepted a Url as an attribute parameter in xml.

attrs.xml:

    <declare-styleable name="HelpLinkButton">
        <attr name="Url" format="string|reference" />
    </declare-styleable>

HelpLinkButton

class HelpLinkButton @JvmOverloads constructor(
    context: Context?, 
    attrs: AttributeSet?, 
    defStyleAttr: Int
) : AppCompatButton(context, attrs, defStyleAttr) {

    var uri: Uri = Uri.EMPTY

    init {
        super.setOnClickListener {}
        context?.let { _context ->
            _context.obtainStyledAttributes(attrs, R.styleable.HelpLinkButton, defStyleAttr, 0)?.let { typedArray ->
                if (typedArray.hasValue(R.styleable.HelpLinkButton_Url)) {
                    typedArray.getResourceId(R.styleable.HelpLinkButton_Url, -1).let {
                        if (it != -1) {
                            uri = Uri.parse(_context.getString(it))
                        } else {
                            typedArray.getString(R.styleable.HelpLinkButton_Url)?.let {
                                uri = Uri.parse(it)
                            }
                        }
                    }
                }
                typedArray.recycle()
            }
        }
    }

    override fun setOnClickListener(l: OnClickListener?) {}
}

test.kt


@RunWith(AndroidJUnit4::class)
class HelpLinkButtonTest {

    @Test
    fun inits_with_string_attr() {
        val builder = Robolectric.buildAttributeSet()
        val url = "http://example.com"
        builder.addAttribute(R.attr.Url, url)

        val button = HelpLinkButton(
                context = ApplicationProvider.getApplicationContext(),
                attrs = builder.build(),
                defStyleAttr = 0
        )

        assertThat(button.uri.toString()).isEqualTo(url)
    }

    @Test
    fun inits_with_resource_attr() {
        val builder = Robolectric.buildAttributeSet()
        builder.addAttribute(R.attr.Url, "@string/upgrade_now_help_url")

        val button = HelpLinkButton(
                context = ApplicationProvider.getApplicationContext(),
                attrs = builder.build(),
                defStyleAttr = 0
        )


       assertThat(button.uri.toString()).isEqualTo("https://dropbit.app/upgrade")
    }


}

I added / to the end of the expectations to show the failed output of the attrs working as expected.

Test Output

[Robolectric] com.coinninja.coinkeeper.view.button.HelpLinkButtonTest.inits_with_resource_attr: sdk=28; resources=BINARY
Called loadFromPath(/system/framework/framework-res.apk, true); mode=binary sdk=28

expected: https://dropbit.app/upgrade/
but was : https://dropbit.app/upgrade
Expected :https://dropbit.app/upgrade/
Actual   :https://dropbit.app/upgrade
<Click to see difference>


    at com.coinninja.coinkeeper.view.button.HelpLinkButtonTest.inits_with_resource_attr(HelpLinkButtonTest.kt:40)

[Robolectric] com.coinninja.coinkeeper.view.button.HelpLinkButtonTest.inits_with_string_attr: sdk=28; resources=BINARY
WARN: No type identifier when getting name for resource number 0x01000000

expected: http://example.com/
but was : http://example.com
Expected :http://example.com/
Actual   :http://example.com
<Click to see difference>


    at com.coinninja.coinkeeper.view.button.HelpLinkButtonTest.inits_with_string_attr(HelpLinkButtonTest.kt:26)


Process finished with exit code 255
user_5058650
Related