CSS animation class Flashing up when using JS

Viewed 113

I have a mobile menu that shows when the window is below 736px. There is a javascript toggle on this menu that adds CSS classes to animate the mobile menu in and out.

When I re-size the window and then open and close the mobile menu it works fine, when the window is then subsequently re-sized again after this, the dropdown mobile menu flashes up for a second when the window hits the CSS media query break point again (736px).

If anyone can help me on this I would be so grateful.

** Note I need the menu to animate out so I can’t just remove the mobileMenuActive class.

codepen: https://codepen.io/emilychews/pen/POeGaN

JS

var mobileMenuButton = document.getElementById("mobile-menu-button")
var mobileMenuItems = document.getElementById("nav-menu-items")

// TOGGLE MOBILE MENU
var mobileMenu = false

function toggleMobileMenu() {

    if (mobileMenu === false) {

      mobileMenuItems.classList.remove("mobileMenuInactive")
      mobileMenuItems.classList.add("mobileMenuActive")
      mobileMenuButton.innerHTML = "Close"
      mobileMenu = true

    } else {

      mobileMenuItems.classList.add("mobileMenuInactive")
      mobileMenuItems.classList.remove("mobileMenuActive")
      mobileMenuButton.innerHTML = "Menu"
      mobileMenu = false

    }
}

mobileMenuButton.addEventListener("click", function() {
    toggleMobileMenu()
}, false)

CSS

body, ul {padding: 0; margin: 0}

/* --- DESKTOP MENU STYLING  ---*/

#main-header {width: 100%; height: 100px;}

#mobile-menu-button {display: none;}

#main-navigation {
  position: relative;
  width: 100%;
  height: 100px;
  background: red;
  display: flex;
  justify-content: space-between;
  box-sizing: border-box;
  padding: 10px 5% 10px 5%;
  align-items: center;
}

ul#nav-menu-items {
  display: flex;
  margin-left: auto;
}

#main-navigation ul li {list-style-type: none;}

ul#nav-menu-items li a {
  padding: 10px 15px;
  margin: 0 5px;
  box-sizing: border-box;
  background: yellow;
  text-decoration: none;
  color:#000;
}

#main-navigation ul#nav-menu-items li a:hover {
  color:blue;
  transition: color .25s;
}

/* --- MOBILE MENU AND DROPDOWN  ---*/

@media screen and (max-width : 736px) {

  #main-navigation {justify-content: flex-end;}

  #mobile-menu-button {
    display: flex;
    justify-content: center;
    background: blue;
    color: white;
    padding: 10px 15px;
    min-width: 75px;
    cursor: pointer;}

/*   dropdown mobile menu */
  ul#nav-menu-items {
    opacity: 0;
    display: flex;
    flex-direction: column;
    align-items: flex-start;
    min-width: 150px;
    background: blue;
    position: absolute;
    right: 5%;
    top: 100px;
    padding: 10px 0px;
  }

  ul#nav-menu-items li {
    padding: 10px 10px;
  }

  ul#nav-menu-items li a {
    padding: 10px 15px;
    color: white;
    background: transparent;
  }

  ul#nav-menu-items li a:hover {
    color: lightblue;
  }

/* -------- MOBILE CLASSES ADDED WITH JavaScript*/

#nav-menu-items.mobileMenuActive {
  animation: showMobileMenu .5s ease-in forwards;
}

@keyframes showMobileMenu {
  0% {opacity: 0;}
  100% {opacity: 1;}
}

#nav-menu-items.mobileMenuInactive {
  animation: removeMobileMenu .5s ease-out forwards;
}

@keyframes removeMobileMenu {
  0% {opacity: 1;}
  100% {opacity: 0;}
}

} /*END OF MOBILE MENU STYLING*/

HTML

<header id="main-header">
  <nav id="main-navigation"> 
    <ul id="nav-menu-items">
      <li class="menu-item menu-item-1"><a href="https://www.google.com">News</a></li>
      <li class="menu-item menu-item-2"><a href="https://www.google.com">About</a></li>
      <li class="menu-item menu-item-3"><a href="https://www.google.com">Contact</a></li>
    </ul>

<!-- button for triggering mobile nav -->
    <div id="mobile-menu-button">Menu</div>

  </nav>
</header>
2 Answers

An option could be to use the window resize event and remove the mobileMenuInactive class. And then Your code adds it again when you click on "Menu".

window.addEventListener('resize', function(){
    mobileMenuItems.classList.remove("mobileMenuInactive");
});

Try this JS code

    var mobileMenuButton = document.getElementById("mobile-menu-button")
    var mobileMenuItems = document.getElementById("nav-menu-items")

    // TOGGLE MOBILE MENU
    var mobileMenu = false

    function toggleMobileMenu() {

        if (mobileMenu === false) {
            mobileMenuItems.classList.add("mobileMenuActive")
            mobileMenuButton.innerHTML = "Close"
            mobileMenu = true
        } else {
            mobileMenuItems.classList.remove("mobileMenuActive")
            mobileMenuButton.innerHTML = "Menu"
            mobileMenu = false
        }

    }

    mobileMenuButton.addEventListener("click", function() {
        toggleMobileMenu()
    }, false)
Related