Recycler View not saving state of Views

One problem is that your code is neither minimal nor complete and verifiable. So I had to make up an example which you will have to adopt to your own needs.

The "single array of objects" I was talking about consists of objects of the class DataItem with one int and two booleans members.

public class DataItem{
    int dataItem;
    boolean visible1;
    boolean visible2;

    public DataItem(int dataItem, boolean visible1, boolean visible2){
        this.dataItem = dataItem;
        this.visible1 = visible1;
        this.visible2 = visible2;
    }
}

onCreate() inside my activity looks like this:

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity);

    int dataItemsLength = 50;
    ArrayList<DataItem> dataItems = new ArrayList<>();
    for (int i = 0; i < dataItemsLength; i++) {
        dataItems.add(new DataItem(i, true, true));
    }
    RecyclerView rv = findViewById(R.id.rv);
    Menu_Detail_Adapter adapter = new Menu_Detail_Adapter(this, dataItems);
    rv.setLayoutManager(new LinearLayoutManager(this));
    rv.setAdapter(adapter);
}

While in your code it is unclear where your data comes from, here I chose the approach to "make" the data (you will probably want to "read" it) in the activity and pass it to the adapter. In principal, you could also do this inside the adapter.

I used a very simple layout for the RecyclerView:

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content">

    <android.support.v7.widget.RecyclerView
        android:id="@+id/rv"
        android:layout_width="match_parent"
        android:layout_height="wrap_content" />

</RelativeLayout>

And an only slightly more complex layout for the items:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical">

    <RelativeLayout
        android:id="@+id/rl1"
        android:layout_width="match_parent"
        android:layout_height="25dp"
        android:background="@android:color/holo_orange_light">

       <TextView
            android:id="@+id/tv1"
            android:layout_width="match_parent"
            android:layout_height="match_parent" />
    </RelativeLayout>

    <RelativeLayout
        android:id="@+id/rl2"
        android:layout_width="match_parent"
        android:layout_height="25dp"
        android:background="@android:color/holo_orange_dark">

        <TextView
            android:id="@+id/tv2"
            android:layout_width="match_parent"
            android:layout_height="match_parent" />
    </RelativeLayout>
</LinearLayout>

And, most importantly, the adapter:

public class Menu_Detail_Adapter extends RecyclerView.Adapter<Menu_Detail_Adapter.ViewHolder> {
    private ArrayList<DataItem> dataItems;
    private final LayoutInflater inflater;

    Menu_Detail_Adapter(Context context, ArrayList<DataItem> dataItems) {
        this.dataItems = new ArrayList<>();
        this.dataItems.addAll(dataItems);
        this.inflater = LayoutInflater.from(context);
    }

    @Override
    public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
        return new ViewHolder(inflater.inflate(R.layout.list_item, parent, false));
    }

    @Override
    public void onBindViewHolder(ViewHolder holder, int position) {
        holder.rl1.setVisibility(dataItems.get(position).visible1 ? View.VISIBLE : View.INVISIBLE);
        holder.tv1.setText(String.valueOf(dataItems.get(position).dataItem));
        holder.rl2.setVisibility(dataItems.get(position).visible2 ? View.VISIBLE : View.INVISIBLE);
    }

    @Override
    public int getItemCount() {
        return dataItems.size();
    }

    public class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {
        RelativeLayout rl1, rl2;
        TextView tv1;

        ViewHolder(View itemView) {
            super(itemView);
            rl1 = itemView.findViewById(R.id.rl1);
            rl2 = itemView.findViewById(R.id.rl2);
            rl1.setOnClickListener(this);
            rl2.setOnClickListener(this);
            tv1 = itemView.findViewById(R.id.tv1);
            ((TextView) itemView.findViewById(R.id.tv2)).setText("default");
        }

        @Override
        public void onClick(View view) {
            if (view.getId() == R.id.rl1) {
                if (view.getVisibility() == View.VISIBLE) {
                    view.setVisibility(View.INVISIBLE);
                    dataItems.get(getAdapterPosition()).visible1 = false;
                } else {
                    view.setVisibility(View.VISIBLE);
                    dataItems.get(getAdapterPosition()).visible1 = true;
                }
            } else if (view.getId() == R.id.rl2) {
                if (view.getVisibility() == View.VISIBLE) {
                    view.setVisibility(View.INVISIBLE);
                    dataItems.get(getAdapterPosition()).visible2 = false;
                } else {
                    view.setVisibility(View.VISIBLE);
                    dataItems.get(getAdapterPosition()).visible2 = true;
                }
            }
        }
    }
}

A few comments on the adapter:

• Make sure not to hard-code any visibilities inside onBindViewHolder(). Use your data set instead.

• Attach the onClickListeners inside the constructor of the ViewHolder class. If you prefer, you can add the listeners as anonymous classes and avoid the if-clauses of a unified onClick method. That's mostly a matter of taste.

• Inside the listener(s), be careful to do both: refresh the view and update the model. This is the crucial point.

• For your purposes, do not use notifyDataSetChanged. This is only necessary, if you add or remove DateItems from the ArrayList<DataItem> called dataItems.

Maybe you can create a second arrayList, using an Object containing 2 boolean, trues by default. Then everytime you change to GONE or VISIBLE, you change the boolean value.

When you initialize your viewholder you give this second arraylist the same size than your current arrayList.

And in the onBindviewHolder, you set the visibility according to boolean status (so by default it will be true), then on your onClickListener you change the value of the booleans.

When you want your item state to be depended upon dynamic value changes you might want to consider putting that values into the object (from the array) itself, and use it instead of depending on the viewholder cached memory