Mock a service of a service in another service Junit

user_3152686 0
Viewed 9814

I have the following service :

@Service
public class AccountServiceImpl implements AccountService {

    @Autowired
    protected ContractService contractService;

    private void saveInCache(MultipartFile multipartFile) {
        this.contractService.saveInCache(multipartFile);
    }
}

and another service

@Service
public class ClientServiceImpl implements ClientService {

    @Autowired
    protected ContractService contractService;

    private void getInfoOfFile(String multipartFileId) {
        DocumentInfo document = this.contractService.getInfo(multipartFileId);
        ///
    }
}

and I have my Junit

public class ClientControllerTest extends ApiWebTest {

  @Mock
  protected ContractService contractService;

  @Autowired
  @InjectMocks
  protected ClientService clientService = new ClientServiceImpl();

  @Before
  private void setup() {
     MockitoAnnotations.initMocks(this);
  }

  @Test
  private void testGetInfo() {
     // Code
     DocumentInfo multipartFile = new DocumentInfo();
     multipartFile.setMultipartFileId(1234);
     when(this.contractService.getInfo(multipartFile.getMultipartFileId())).thenReturn(multipartFile);

   // Test the Client service 'getInfoOfFile' method.
  }
}

When i run this test in debug mode, I see that the this.contractService.getInfo(multipartFileId); is returning me 'null'.

Where am I going wrong in mocking.

I have just mocked the ContractService in my JUnit. Do I need to mock even the AccountServiceImpl as well ?

EDIT : Adding the saveInCache and getInfo methods

private DocumentInfo getInfo(String documentId) {
        if (StringUtils.isEmpty(documentId)) {
            return null;
        }
        WriteLock lock = this.readWriteLock.writeLock();
        try {
            lock.lock();
            DocumentInfo cachedDocument = this.documentCache.get(documentId);
            return cachedDocument;
        } finally {
            if (lock != null) {
                lock.unlock();
            }
        }
    }

private DocumentInfo saveInCache(StreamingStorage document) {
        if (document == null) {
            throw new InvalidParameterException("Creative document is required to put into cache.");
        }
        WriteLock lock = this.readWriteLock.writeLock();
        try {
            lock.lock();
            DocumentInfo newCachedDocument = this.documentCache.put(document.getDocumentId(), document);
            return newCachedDocument;
        } finally {
            if (lock != null) {
                lock.unlock();
            }
        }
    }
mockito junit spring java
4 Answers

Root cause: You didn't inject the ContractService into the ClientService.

I think you can solve the problem much easier by using ReflectionTestUtils. It means you will inject the mocked ContractService to the AccountServiceImpl.

public class ClientControllerTest extends ApiWebTest {
  protected ClientService clientService = new ClientServiceImpl();
  private ContractService contractService;
  @Test
  private void testGetInfo() 
  {
     // Code
     DocumentInfo multipartFile = new DocumentInfo();
     multipartFile.setMultipartFileId(1234);
     contractService= EasyMock.createNiceMock(ContractService.class);
     ReflectionTestUtils.setField(clientService, "contractService", contractService);
     EasyMock.expect(contractService.getInfo(multipartFile.getMultipartFileId())).andReturn(multipartFile).anyTimes();
     EasyMock.replay(contractService);
  }
}

You can apply the same for JUnit

user_65502620
Related