Error: data and salt arguments required

user_5180082 0
Viewed 55670

I am trying to save a user to mongodb database using post request as follow, but I got the error bcrypt Error: data and hash arguments required .It's a pretty simple set up of the code but i can't figure out anything wrong with it. models/users.js 

const mongoose = require('mongoose');
const bcrypt = require('bcrypt');
const confic = require('../models/users');

// User schema
const UserSchema = mongoose.Schema({
 name: {
  type: String,
 },
 email: {
  type: String,
  required: true
 },
 username:{
  type: String,
  required: true
 },
 password: {
  type: String,
  required: true
 }
});

const User = module.exports = mongoose.model('User', UserSchema);

module.exports.getUserById = function(id,callback){
 User.findById(id,callback);
}

module.exports.getUserByUsername = function(username,callback){
 const query = {username:username}
 User.findOne(query,callback);
}

module.exports.addUser= function (newUser, callback) {
   bcrypt.genSalt(10,(err,salt) => {
    bcrypt.hash(newUser.password, salt , (err, hash) =>{
        if(err) throw (err);

        newUser.password=hash;
        newUser.save(callback);
    });
   });
}
routes/users.js

const jwt = require('jsonwebtoken');
User = require('../models/users')

// // Register
router.post('/register', (req, res, next) => {
  var newUser = new User({
    name: req.body.name,
    email: req.body.email,
    username: req.body.username,
    password: req.body.password
  });

  User.addUser(newUser, (err, User) => {
    if(err){
      // res.json({success: false, msg:'Failed to register user'});
    } else {
      // res.json({success: true, msg:'User registered'});
    }

  });

});

// Authenticate
router.post('/authenticate', (req, res, next) => {
  res.send('AUTHENTICATE');
});

// Profile
router.get('/profile', (req, res, next) => {
  res.send('PROFILE');
});

module.exports = router;
Server was running but after using postman chrome post request error are shown and server stop working as errors shown in image.enter image description here

node.js mongodb javascript
5 Answers

Remove the arrow => in bcrypt.hash() . Use old fashioned method definition function() {}

user_114313120

Per mongoose docs: https://mongoosejs.com/docs/faq.html

Q. I'm using an arrow function for a virtual, middleware, getter/setter, or method and the value of this is wrong.

A. Arrow functions handle the this keyword much differently than conventional functions. Mongoose getters/setters depend on this to give you access to the document that you're writing to, but this functionality does not work with arrow functions. Do not use arrow functions for mongoose getters/setters unless do not intend to access the document in the getter/setter.

Admin1

Make sure the properties are as they are being supplied, in my case, I was sending a Password property with a capital P and then passing the password with a small p letter to the hash function.

user_43082860

When I was testing with plain text mode, I got this error (data and salt argument required), once I did change to json, it was ok.

user_181611840
Related