React Router 4, How do I get a valid match url with route render or with withRouter?

Viewed 3101

The match object I receive using either the render property on the Route component or using an HOC from withRouter always produces a match object that is wrong. The location object is correct. The match url property is always '/'

Here is a code pen that shows the problem React Router 4 match woes

const { render } = ReactDOM

    const {
      HashRouter,
      Route,
      Link
    } = ReactRouterDOM

    const App = () => (
      <HashRouter>
        <div>
          <AddressBar/>

          <ul>
            <li><Link to="/">Home</Link></li>
            <li><Link to="/about">About</Link></li>
            <li><Link to="/topics">Topics</Link></li>
          </ul>

          <hr/>

          <Route exact path="/" component={Home}/>
          <Route path="/about" component={About}/>
          <Route path="/topics" component={Topics}/>
        </div>
      </HashRouter>
    )

    const Home = () => (
      <div>
        <h2>Home</h2>
      </div>
    )

    const About = ({ match }) => (
      <div>
        <h2>About</h2>
        <h3>Match: {match.url}</h3>
      </div>
    )

    const Topics = ({ match }) => (
      <div>
        <h2>Topics</h2>
        <ul>
          <li><Link to={`${match.url}/rendering`}>Rendering with React</Link></li>
          <li><Link to={`${match.url}/components`}>Components</Link></li>
          <li><Link to={`${match.url}/props-v-state`}>Props v. State</Link></li>
        </ul>

        <Route path={`${match.url}/:topicId`} component={Topic}/>
        <Route exact path={match.url} render={() => (
          <h3>Please select a topic.</h3>
        )}/>
      </div>
    )

    const Topic = ({ match }) => (
      <div>
        <h3>{match.params.topicId}</h3>
        <h3>Match: {match.url}</h3>
      </div>
    )

    const AddressBar = () => (
      <Route render={({ location: { pathname }, match: {url}, goBack, goForward }) => (
        <div className="address-bar">
          <div>
            <button
              className="ab-button"
              onClick={goBack}
            >◀︎</button>
          </div>
          <div>
            <button
              className="ab-button"
              onClick={goForward}
            >▶</button>
          </div>
          <div className="url">URL: {pathname} Match: {url}</div>
        </div>

      )}/>
    )

    render(<App/>, document.getElementById('root'))

Click on the About link (Topics has the same issue): notice the AddressBar, which uses Route render, at the top always shows

> Match: /

while at the bottom of the screen the Component displays the correct match.url

Match: /about

What am I doing wrong? How do I get a valid match object into the AddressBar?

Here is the ugly hack I used for my specific route where I need to know the specific 'league' parameter.

let keys = []
let path = '/*/:league/:id';
if (this.path.split('/').length === 3)
  path = '/*/:league';
let re = pathToRegexp(path, keys);
const result = re.exec(this.path)
if (result && result[2])
  this.store.setLeague(result[2]);
2 Answers

I guess whenever you need to use match, you also need to combine it with pathname

example

var match = this.props.match;
<Link className = 'xxx' to = {{pathname:match.url + '/target'}}
Related