Angularjs function inside ng-repeat called too many times

Viewed 1627

I've got a function in my controller very easy that just stamp a console.log. I need to conditioning a button using a function but inside the ng-repeat the controller repeats everything many times! Is it normal? Is it possible avoid this? Thanks. An example here http://plnkr.co/edit/sME67gQEZQSLI9FOwEAG?p=preview

relative code:

<!DOCTYPE html>
<html>

  <head>
    <script data-require="angular.js@1.4.5" data-semver="1.4.5" src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.5/angular.min.js"></script>
    <link rel="stylesheet" href="style.css" />
    <script src="script.js"></script>
  </head>

  <body ng-app="DigestApp">
    <div ng-controller="UserCtrl as uc">
      <h1>Please open the console to see</h1>
      <ul>
        <li ng-repeat="user in uc.users" ng-class="uc.userClasses(user)">
          {{user.name}}
          <button ng-if="uc.isUserEnabled(user)"
                  ng-click="uc.disableUser(user)">Disable</button>
        </li>
      </ul>
    </div>
  </body>

</html>

javascript:

angular.module("DigestApp", [])

.controller('UserCtrl', function(User) {
  var vm = this;

  vm.users = User.list();

  vm.isUserEnabled = function(user) {
    console.log('isUserEnabled');
    return user.active;
  };

  vm.userClasses = function(user) {
    console.log('userClasses');
    return []
      .concat(user.active ? ['user-active'] : [])
      .concat(user.loggedIn ? ['user-logged-in'] : [])
      .concat(user.isMe ? ['user-is-me'] : [])
      .join(' ');
  };

  vm.disableUser = function(user) {
    user.active = false;
  };
})

.factory('User', function() {
  return {
    list: function() {
      return [{
        name: "me",
        active: true,
        loggedIn: true,
        isMe: true
      }];
    }
  };
});
2 Answers
Related