Should I consider that declaring all C static functions is a good practice?

Viewed 325

I recently wrote a piece of C code like that:

static void func1()
{

}

static void func2()
{

}


typedef void (*func_t)(void);

const func_t lookUpTable[FUNC_COUNT] =
{
    [FUNC1] = &func1,
    [FUNC2] = &func2
}

An other programmer worked on the same file and changed it to:

static void func1();
static void func2();

typedef void (*func_t)(void);

const func_t lookUpTable[FUNC_COUNT] =
{
    [FUNC1] = &func1,
    [FUNC2] = &func2
}

static void func1()
{

}

static void func2()
{

}

Since the funcN functions are only called thru the lookup table, I don't actually need the declarations of those functions.

Is it a matter of taste, or is there a coding style that is considered as a good/bad practice?

1 Answers
Related