Is it safe to finish an android activity from a background thread?

user_9636 0
Viewed 4668

In Android, is it safe to call Activity.finish() from a background thread, or can it only called from the main thread? The documentation doesn't mention anything about thread safety of this method.

thread-safety android-activity android
2 Answers

No, it is not.

The code uses at least one variable, mFinished, without synchronization. Full stop.

   public void finish() {
    if (mParent == null) {
        int resultCode;
        Intent resultData;
        synchronized (this) {
            resultCode = mResultCode;
            resultData = mResultData;
        }
        if (false) Log.v(TAG, "Finishing self: token=" + mToken);
        try {
            if (resultData != null) {
                resultData.setAllowFds(false);
            }
            if (ActivityManagerNative.getDefault()
                .finishActivity(mToken, resultCode, resultData)) {
                mFinished = true;
            }
        } catch (RemoteException e) {
            // Empty
        }
    } else {
        mParent.finishFromChild(this);
    }
}
user_9452260

Probably the result could be unexpected. I'd use a Handler or some other way to send to the activity the order to kill itself in the next iteration.

user_23574110
Related