Django dictionary with the same value

user_18279398 0
Viewed 40

I'm trying to create a dictionary with some specific values but it gets the same values multiple times:

readers = Readers.objects.all()
count = 0
readersResult = {}
test = {
    "avatar": "",
    "firstName": "",
    "percent": "",
    "lastName": ""
}
for reader in readers:
    test["percent"] = "value from another place"
    test["firstName"] = reader.firstName
    test["lastName"] = reader.lastName
    test["avatar"] = reader.avatar

    print("TEST: ", test)

    readersResult[count] = test
    count = count + 1

print("RESULT":, readersResult)

My output is:

web_1  | TEST:  {'avatar': '/images/avatars/71.png', 'firstName': 'abc', 'percent': '37.08999158957107', 'lastName': 'def'}
web_1  | TEST:  {'avatar': '/images/avatars/61.png', 'firstName': 'abc', 'percent': '4.037005887300253', 'lastName': 'def'}
web_1  | RESULT:  {0: {'avatar': '/images/avatars/61.png', 'firstName': 'abc', 'percent': '4.037005887300253', 'lastName': 'def'}, 1: {'avatar': '/images/avatars/61.png', 'firstName': 'abc', 'percent': '4.037005887300253', 'lastName': 'def'}}

What am I doing wrong?

dictionary django-views django python
3 Answers

You are assigning the same dictionary (test) to multiple entries in readersResult, as opposed to making a new one for each reader.

user_5352750

Here, in your code, you make a dict named test, and then in each loop iteration you add it again to the readersResult.

test = {
    "avatar": "",
    "firstName": "",
    "percent": "",
    "lastName": ""
}
for reader in readers:
    test["percent"] = "value from another place"
    test["firstName"] = reader.firstName
    test["lastName"] = reader.lastName
    test["avatar"] = reader.avatar

    print("TEST: ", test)

    readersResult[count] = test
    count = count + 1

You need to create a new dict with each loop iteration. So exchange this part of your code to this:

for reader in readers:
    test = {}
    test["percent"] = "value from another place"
    test["firstName"] = reader.firstName
    test["lastName"] = reader.lastName
    test["avatar"] = reader.avatar

    print("TEST: ", test)

    readersResult[count] = test
    count = count + 1

PS: You don't need to use the below code to define the keys in the dictionary and then set its values somewhere else. So you can change:

teste = {
    "avatar": [],
    "firstName": [],
    "percent": [],
    "lastName": []
}

with:

test = {}
user_48176490

You can use a list as the dictionary value:

readers = Readers.objects.all()
count = 0
readersResult = {}
test = {
    "avatar": [],
    "firstName": [],
    "percent": [],
    "lastName": []
}
for reader in readers:
    test["percent"].append("value from another place")
    test["firstName"].append(reader.firstName)
    test["lastName"].append(reader.lastName)
    test["avatar"].append(reader.avatar)

    print("TEST: ", test)

    readersResult[count] = test
    count = count + 1

print("RESULT":, readersResult)

Examples can be found here.

user_182687570
Related