Add value after date is end in list kotlin

As I understand what you want, You need something like this:

var previousDate: String? = null
var i = -1
while (i < list.size) {
    i++
    val currentDate = list[i].date
    previousDate?.let {
        if (currentDate != previousDate) {
            list.add(i + 1, Conversation(ConversationType.TIME.value, Sender(null, it)))
        }
    }
    previousDate = currentDate
}

Other people already provided solutions based on manual iteration over indexes. Alternative that could be easier to read is to use mutable iterators. The resulting code is almost the same as your original attempt:

val iter = list.listIterator()
var previousDate = iter.next().sender?.date
iter.forEach { conversation ->
    val date = conversation.sender?.date
    if (date != previousDate) {
        iter.add(Conversation(...))
        previousDate = date
    }
}

With mutable iterators we can just add an item at the point where it is needed during iterating. We don't need to manage indexes manually.

This solution will throw an exception if the list is empty, so we should probably add a check for that case. You should also consider the case where sender or date is null. All solutions provided so far will behave odd in this case and you didn't specify what is your expected behavior.

Since you want to add items to the list while you're iterating it, you need to iterate the indices so you can insert items as you go. Since the list is growing as you go, you need to use a while loop instead of a for loop with the original indices.

var previousDate: String? = null
var i = 0
while (i < list.size) {
    val newDate = list[i].date
    if (newDate != previousDate && previousDate != null) {
        list.add(i++, Conversation(ConversationType.TIME.value, Sender(null, previousDate)))
    }
    previousDate = newDate
    i++
}

To explain my suggestion about simplifying using sealed interfaces, here is how I would redesign. I would replace your above classes with:

sealed interface Conversation {
    val date: String
}

sealed interface ConversationMessage: Conversation {
    val senderId: Int
}

data class IncomingConversation(
    override val date: String,
    override val senderId: Int
): ConversationMessage

data class OutgoingConversation(
    override val date: String,
    override val senderId: Int
): ConversationMessage

data class TimeStampConversation(override val date: String): Conversation

Then you don't have to worry about anything being null, you don't have to unpack enum values, and all the constructors are much easier to use. You can use when statements with is checks to determine which view holder to work with in your RecyclerView.