How to add string.join to foreach loop

Question

I show the categories of my i'th product on the View, but I want to add a link and put commas between them.

@for (int i = 0; i < Products.Count(); i++)
{
    
        
             @Model.Products[i].ProductName 
            @foreach (var item in Model.Products[i].ProductCategories)
            {
                 @item.ItemName, 
            }

It looks like this => Computer, Technology, Desktop,

I want this => Computer, Technology, Desktop

I don't want a comma in the last item

I can show it this way but I can't add

 @string.Join(", ", Model.Products[i].ProductCategories.Select(p => p.Category.CategoryName))

user_2557128 · Answer

I think you can use LINQ instead of foreach:

@for (int i = 0; i < Products.Count(); i++)
{
    
        
             @Model.Products[i].ProductName 
            @Html.Raw(String.Join(", ", Model.Products[i].ProductCategories.Select(category => $@"{Html.Encode(category.CategoryName)}")))

But I won't say this is the most Razor way to do it. You should probably be using something like Html.ActionLink at this point instead of manually putting in the a tag.

user_6842716 · Answer

Using a brute force approach…

Have you considered using a for loop instead of a foreach loop? Inside the for loop, if the loop index j is less than the collection count – 1, then add the comma.

Example, using your code structure…

@for (int j = 0; j < Model.Products[i].ProductCategories.Count(); j++) 
{
    If (j < Model.Products[i].ProductCategories.Count() – 1)
    {
         Model.Products[i].ProductCategories[j].ItemName, 
     }
     else
     {
          Model.Products[i].ProductCategories[j].ItemName
     }
}

user_2200185 · Answer

Perhaps you could do something like this. Could not test it, but should capture the gist.


    @string.Join(
        ", ", 
        Model.Products[i]
            .ProductCategories
            .Select(
                p => "

How to add string.join to foreach loop

3 Answers