Why is the RecyclerView not working when the compiler isn't giving any errors?

Question

Usually, I don't ask questions like these; I do my research and at least am able to identify the problem before asking on StackOverflow. But this time, even after thoroughly researching and looking over my code over and over again, I can't even identify the problem. So I apologize for asking such a broad question.

I have some RecyclerViews in my app (9, to be exact). One of them is working, eight are not. I have looked over my code over and over again, but I can't seem to identify the problem. I'll paste the code for one recycler view and its adapter. This is what my layout for a single element looks like:

And here is my code for the layout of a single element (I'm just posting it for people to know the ids):

And here is my code for the adapter of the RecyclerView:

    package com.example.treeapp;

    import android.content.Intent;
    import android.view.LayoutInflater;
    import android.view.View;
    import android.view.ViewGroup;
    import android.widget.ImageView;
    import android.widget.TextView;

    import androidx.annotation.NonNull;
    import androidx.recyclerview.widget.RecyclerView;

    import com.mikhaellopez.circularimageview.CircularImageView;

    import java.util.List;

    public class DonorOrdersAdapter extends RecyclerView.Adapter {
        public String email;
        public static DownloadImageTask downloadImageTask;

        public static class DonorOrdersViewHolder extends RecyclerView.ViewHolder {
            public CircularImageView imageView;
            public TextView orderTextView;
            public TextView planterTextView;
            public ImageView markFulfilledIcon;
            public ImageView messageIcon;

            DonorOrdersViewHolder(View view) {
                super(view);

                imageView = view.findViewById(R.id.image_view);
                orderTextView = view.findViewById(R.id.text_view_order);
                planterTextView = view.findViewById(R.id.text_view_planter);
                markFulfilledIcon = view.findViewById(R.id.mark_fulfilled_icon);
                messageIcon = view.findViewById(R.id.message_icon);
                downloadImageTask = new DownloadImageTask(imageView);
            }
        }

        DonorOrdersAdapter(String email) {
            this.email = email;
        }

        List orders = MainActivity.database.ordersDao().getOrdersByDonor(email);

        @NonNull
        @Override
        public DonorOrdersViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
            View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.donor_order, parent, false);

            return new DonorOrdersViewHolder(view);
        }

        @Override
        public void onBindViewHolder(@NonNull DonorOrdersViewHolder holder, int position) {
            final int current = orders.get(position);
            final String planterEmail = MainActivity.database.ordersDao().getPlanter(current);

            if (MainActivity.database.plantersDao().getImageUrl(planterEmail) != null) {
                downloadImageTask.execute(MainActivity.database.plantersDao().getImageUrl(planterEmail));
            }

            holder.orderTextView.setText(MainActivity.database.ordersDao(  ).getTrees(current) + " trees");
            holder.planterTextView.setText(MainActivity.database.plantersDao().getName(planterEmail) + ", $" +
                                           MainActivity.database.ordersDao().getPayment(current));

            holder.markFulfilledIcon.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View view) {
                    Intent fulfillIntent = new Intent(view.getContext(), ConfirmPaymentActivity.class);
                    fulfillIntent.putExtra("email", email);
                    fulfillIntent.putExtra("orderId", current);

                    view.getContext().startActivity(fulfillIntent);
                }
            });

            holder.messageIcon.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View view) {
                    Intent messageIntent = new Intent(view.getContext(), MessageActivity.class);
                    messageIntent.putExtra("email", email);
                    messageIntent.putExtra("peerEmail", planterEmail);
                    messageIntent.putExtra("archived", 0);

                    view.getContext().startActivity(messageIntent);
                }
            });
        }

        @Override
        public int getItemCount() {
            return orders.size();
        }
    }

I am using a SQLite table using the room library. Here is the code for a row of the table:

    package com.example.treeapp;

    import androidx.room.ColumnInfo;
    import androidx.room.Entity;
    import androidx.room.PrimaryKey;

    @Entity(tableName = "Orders")
    public class Order {
        @PrimaryKey(autoGenerate = true)
        public int id;

        @ColumnInfo(name = "Donor")
        public String donorEmail;

        @ColumnInfo(name = "Planter")
        public String planterEmail;

        @ColumnInfo(name = "Trees")
        public int trees;

        @ColumnInfo(name = "Payment")
        public int payment;

        @ColumnInfo(name = "Fulfilled")
        public int fulfilled;
    }

And here is the code for the Data Access Object:

    package com.example.treeapp;

    import androidx.room.Dao;
    import androidx.room.Query;

    import java.util.List;

    @Dao
    public interface OrdersDao {
        @Query("INSERT INTO Orders (Donor, Planter, Trees, Payment, Fulfilled) VALUES (:donorEmail, :planterEmail, :trees, :payment, 0)")
        void create(String donorEmail, String planterEmail, int trees, int payment);

        @Query("SELECT Donor FROM Orders WHERE id = :id")
        String getDonor(int id);

        @Query("SELECT Planter FROM Orders WHERE id = :id")
        String getPlanter(int id);

        @Query("SELECT Trees FROM Orders WHERE id = :id")
        int getTrees(int id);

        @Query("SELECT Payment FROM Orders WHERE id = :id")
        int getPayment(int id);

        @Query("SELECT Fulfilled FROM Orders WHERE id = :id")
        int getFulfilled(int id);

        @Query("UPDATE Orders SET Fulfilled = 1 WHERE id = :id")
        void markFulfilled(int id);

        @Query("SELECT id FROM Orders WHERE Donor = :donorEmail AND Fulfilled = 0")
        List getOrdersByDonor(String donorEmail);

        @Query("SELECT id FROM Orders WHERE Planter = :planterEmail AND Fulfilled = 0")
        List getOrdersToPlanter(String planterEmail);

        @Query("SELECT id FROM Orders WHERE Fulfilled = 0")
        List getUnfulfilledOrders();
    }

And here is my code for the activity in which the recycler views are used:

    package com.example.treeapp;

    import androidx.appcompat.app.AppCompatActivity;
    import androidx.recyclerview.widget.LinearLayoutManager;
    import androidx.recyclerview.widget.RecyclerView;

    import android.os.Bundle;

    public class DonorOrdersActivity extends AppCompatActivity {
        private String email;
        private RecyclerView recyclerView;
        private RecyclerView.Adapter adapter;
        private RecyclerView.LayoutManager layoutManager;

        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_donor_orders);

            email = getIntent().getStringExtra("email");
            recyclerView = findViewById(R.id.recycler_view);
            adapter = new DonorOrdersAdapter(email);
            layoutManager = new LinearLayoutManager(this);

            recyclerView.setAdapter(adapter);
            recyclerView.setLayoutManager(layoutManager);
        }
    }

If anyone is able to figure out what's wrong with my RecyclerViews, please tell me.

**EDIT: ** I have tested that my database actually contains the orders by logging data from the orders table.

user_6217595 · Answer

If you see your logcat, you can see E/RecyclerView: No adapter attached; skipping layout. So the solution is change this :

recyclerView.setAdapter(adapter);
recyclerView.setLayoutManager(layoutManager);

to this :

recyclerView.setLayoutManager(layoutManager);
recyclerView.setAdapter(adapter);

user_8523867 · Answer

If getItemCount() returns zero RV wont inflate any viewHolders. Usually if nothing is shown in Rv, putting breakpoints or logging will help identifying the issue.

user_6489291 · Answer

Not a best solution but please specify adapter.notifyDataSetChanged();. Worth a shot.

user_12877007 · Answer

im not so professional but why not you are using Log? in adapter under onbindviewholder you should log.d(email) you are sending for you activity and also log the data that you are trying to get from sql using this email, by doing this you will become sure of if the data is in adapter or not. if the data is present its means there is a problem with Recyclerview View, means data is good to go but recylerview is not able to show the data to user. else obviously you are not getting the data right.

 FilenameSimpleAdapter listAdapter = new FilenameSimpleAdapter(listfilenames,MapsActivity.this);
    RecyclerView.LayoutManager mLayoutManager = new LinearLayoutManager(this);
    recyclerView.setLayoutManager(mLayoutManager);
    recyclerView.setItemAnimator(new DefaultItemAnimator());
    recyclerView.addItemDecoration(new DividerItemDecoration(this, LinearLayoutManager.VERTICAL));
    recyclerView.setAdapter(listAdapter);

That is not something special but we are just changing that how will recycler view display the data.

Why is the RecyclerView not working when the compiler isn't giving any errors?

4 Answers