Can you append the result of multiple 'get' requests and send that out as a 'get 'response?

user_13265155 0
Viewed 51

I've been toying with this for the past few hours and I can't for the life of me figure out why it's returning a list of nulls.

function getFile(file) {
    var request = require("request");
    request(
      {
      uri:
          file,
      method: "GET",
      gzip: true,
      qs: {
          format: "json",
      },
      },
      (err, resp, body) => {
        console.log(body);
        return body
      }
    )
}

async function download_tire_json_from_firebase() {

  let files = ['https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fforceum.json?alt=media&token=ed9db67c-d744-414f-8812-21cfbba63447',
                'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fgood-year.json?alt=media&token=1131b553-e2e5-4ff6-87cb-f346e57e389e',
                'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fgt-radial.json?alt=media&token=d2ba3f51-cef7-494e-8006-61d321d677cd',
                'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fkpatos.json?alt=media&token=75743c44-1521-4ff4-8133-e56a474f7c3e',
                'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fland-spider.json?alt=media&token=22a3aa7b-18a9-4bd1-b34b-5ae48cadbc55',
                'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fleao-tires.json?alt=media&token=84dcc7f8-de32-46a9-9aae-854639772975',
                'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fwanli.json?alt=media&token=4bb13f3a-5d9a-4c2d-b558-964ee996a534',
                'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fzeta.json?alt=media&token=c04f973c-2577-4f06-805e-68e46480e9ae'
              ]
  const results = []

  for(const file of files) {
    results.push(getFile(file));
  }
  console.log("Final Result:", results)
  return await Promise.all(results)
}

app.get("/get-tire-data", async (req, res) => {
  let results = await download_tire_json_from_firebase()
  res.send(JSON.stringify(results))
})

What's odd is that in my node console, '' console.log("Final Result:", results) '', prints out the expected list. It's as if somehow that list isn't making it to the 'get-tire-data' get request.

Also if anyone knows how to simplify the above code, I'd also appreciate that thoroughly.

promise async-await node.js javascript
2 Answers

You need to return a Promise in getFile

function getFile(file) {
    var request = require("request");
    return new Promise((resolve, reject) => {
      request(
        {
        uri:
            file,
        method: "GET",
        gzip: true,
        qs: {
            format: "json",
        },
        },
        (err, resp, body) => {
          if (err) {
            reject(err)
          } else {
            resolve(body)
          }
        }
      )
    })
}

You can simplify your code with a library I created.

const { map } = require('rubico')
const request = require('request')

const urls = [
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fforceum.json?alt=media&token=ed9db67c-d744-414f-8812-21cfbba63447',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fgood-year.json?alt=media&token=1131b553-e2e5-4ff6-87cb-f346e57e389e',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fgt-radial.json?alt=media&token=d2ba3f51-cef7-494e-8006-61d321d677cd',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fkpatos.json?alt=media&token=75743c44-1521-4ff4-8133-e56a474f7c3e',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fland-spider.json?alt=media&token=22a3aa7b-18a9-4bd1-b34b-5ae48cadbc55',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fleao-tires.json?alt=media&token=84dcc7f8-de32-46a9-9aae-854639772975',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fwanli.json?alt=media&token=4bb13f3a-5d9a-4c2d-b558-964ee996a534',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fzeta.json?alt=media&token=c04f973c-2577-4f06-805e-68e46480e9ae'
]

const getFile = url => new Promise((resolve, reject) => {
  request({
    uri: url,
    method: "GET",
    gzip: true,
    qs: { format: "json" },
  }, (err, resp, body) => err ? reject(err) : resolve(body))
})

// urls => tire_json_data
const download_tire_json_from_firebase = map(getFile)

app.get("/get-tire-data", async (req, res) => {
  let results = await download_tire_json_from_firebase(urls)
  res.send(JSON.stringify(results))
})
user_89930800

Promise.all expects an array of promises and so getFile method should return a promise. 

const request = require('request');
const files = [
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fforceum.json?alt=media&token=ed9db67c-d744-414f-8812-21cfbba63447',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fgood-year.json?alt=media&token=1131b553-e2e5-4ff6-87cb-f346e57e389e',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fgt-radial.json?alt=media&token=d2ba3f51-cef7-494e-8006-61d321d677cd',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fkpatos.json?alt=media&token=75743c44-1521-4ff4-8133-e56a474f7c3e',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fland-spider.json?alt=media&token=22a3aa7b-18a9-4bd1-b34b-5ae48cadbc55',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fleao-tires.json?alt=media&token=84dcc7f8-de32-46a9-9aae-854639772975',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fwanli.json?alt=media&token=4bb13f3a-5d9a-4c2d-b558-964ee996a534',
  'https://firebasestorage.googleapis.com/v0/b/moberra-tire-api.appspot.com/o/tire-data-eco%2Fzeta.json?alt=media&token=c04f973c-2577-4f06-805e-68e46480e9ae'
];
const getFile = (url) => new Promise((resolve, reject) => {
  request({
      uri: url,
      method: "GET",
      gzip: true,
      qs: {
        format: "json"
      },
    },
    (err, resp, body) => err ? reject(err) : resolve(body)
  )
});
app.get("/get-tire-data", async(req, res) => {
  const results = await Promise.all(files.map(url => getFile(url)));
  res.send(JSON.stringify(results))
});

user_97505490
Related