Bootstrap 4.2.1 - Failed to execute 'querySelector' on 'Document': 'javascript:void(0);' is not a valid selector

Question

I am working on a project which I started building on bootstrap 4.0.0. During this project, I had updated bootstrap regulary whenever the new versions ( 4.1.0 , 4.1.3 ) of bootstrap came and all the things were working perfectly until I have update to bootstrap 4.2.1 from there I encountered error in console when ever I click on the document

Uncaught DOMException: Failed to execute 'querySelector' on 'Document': 'javascript:void(0);' is not a valid selector.

I figured out that it occur due to the dropdown because of this error the dropdown does not work. I also checked, that if I am using href="javascript:void(0);", href="#!" the error occur but if i use anchor tag without href or href="#" then it is working fine.

Note:- I need the solution with href="javascript:void(0); as href="# in the address link does not look pretty and page scrolls up to the top


        
            Dropdown link
        

        
            Action
            Another action
            Something else here

Here is my codepen

user_263875 · Answer

I was having this issue, and a comment on this reported issue clued me into the solution. I was copying the example from the Bootstrap docs, and I had to remove the ID from the parent link, and instead have that ID on the container for the child links, without the aria-labeledby property, and add a reference in the parent link data-target property.

This example shows what I was doing, which caused the console errors:


    
        Commercial
    
    
        Dashboard

This is the solution that worked for me:


    
        Individual
    
    
        Dashboard

user_4025898 · Answer

=== Change in bootstrap.js v4.2.1 ===

Find below block

getSelectorFromElement: function getSelectorFromElement(element) {
  var selector = element.getAttribute('data-target');

  if (!selector || selector === '#') {
    var hrefAttr = element.getAttribute('href');
    selector = hrefAttr && hrefAttr !== '#' ? hrefAttr.trim() : '';
  }

  return selector && document.querySelector(selector) ? selector : null;
},

Need to add try and catch exception only as below

Replace

return selector && document.querySelector(selector) ? selector : null;

with

try {
    return selector && document.querySelector(selector) ? selector : null;
} catch (err) {
    return null;
}

=== Change in bootstrap.min.js v4.2.1 ===

Replace

return e&&document.querySelector(e)?e:null

with

try{return e&&document.querySelector(e)?e:null}catch(err){return null;}

user_5516725 · Answer

Here is the solution that works for me

Snippet from Bootstrap 4.1.3

getSelectorFromElement: function getSelectorFromElement(element) {
    var selector = element.getAttribute('data-target');

    if (!selector || selector === '#') {
      selector = element.getAttribute('href') || '';
    }

    try {
      return document.querySelector(selector) ? selector : null;
    } catch (err) {
      return null;
    }
},

Replace it from Bootstrap 4.2.1

getSelectorFromElement: function getSelectorFromElement(element) {
  var selector = element.getAttribute('data-target');

  if (!selector || selector === '#') {
    var hrefAttr = element.getAttribute('href');
    selector = hrefAttr && hrefAttr !== '#' ? hrefAttr.trim() : '';
  }

  return selector && document.querySelector(selector) ? selector : null;
},

Thanks to PixemWeb github solution

For more info here is the link https://github.com/twbs/bootstrap/issues/27903#issuecomment-449600715

user_7386883 · Answer

getSelectorFromElement: function getSelectorFromElement(element) {
            var selector = element.getAttribute('data-target');
            if (!selector || selector === '#') {
                var hrefAttr = element.getAttribute('href');

                //selector = hrefAttr && hrefAttr !== '#' ? hrefAttr.trim() : '';
                selector = hrefAttr && hrefAttr.indexOf('#') === 0 ? hrefAttr.trim() : '';
            }

            return (selector && document.querySelector(selector)) ? selector : null;
        }

this function through error due to document.querySelector not find id like "#home" so if any string not contain # prefix it through error. so replace this:

selector = hrefAttr && hrefAttr !== '#' ? hrefAttr.trim() : '';

from this

selector = hrefAttr && hrefAttr.indexOf('#') === 0 ? hrefAttr.trim() : '';

user_10738806 · Answer

A suggestion:

Remove the empty href attribute & add cursor:pointer style to make A element clickable.

#dropdownMenuLink {
  cursor: pointer; /* not necessary for Bootstrap */
  color: white /* change if you want */
}




  
    Dropdown link
  

  
    Action
    Another action
    Something else here

user_308578 · Answer

as others said in comments

This is a bug in Bootstrap 4.2.1 and will be fixed in 4.3.0: github.com/twbs/bootstrap/issues/27903

just need to user 4.3.0 of bootstrap

just replace this

with this

user_577543 · Answer

Make sure that the anchor of the dropdown menu item is # instead of a path.

Solution: I use to Link instead of an a in React and replace it with simple and it is working now.

Bootstrap 4.2.1 - Failed to execute 'querySelector' on 'Document': 'javascript:void(0);' is not a valid selector

7 Answers