Angular is it necessary to unsubscribe from this.activatedRoute subscriptions

user_1205871 0
Viewed 2563

My code:

ngOnInit() {

  this.activatedRoute.params.subscribe((params: Params) => {
    // do stuff
  })

  this.activatedRoute.data.subscribe((data: any) => {
    // do stuff
  })

}

My question is ... do I need to unsubscribe from these in ngOnDestroy?

As a matter of habit I always unsub but not sure if it is necessary here.

thanks

rxjs angular
4 Answers

No, you don't need to unsubscribe from route observables

From the Documentation

When subscribing to an observable in a component, you almost always arrange to unsubscribe when the component is destroyed.

There are a few exceptional observables where this is not necessary. The ActivatedRoute observables are among the exceptions.

The ActivatedRoute and its observables are insulated from the Router itself. The Router destroys a routed component when it is no longer needed and the injected ActivatedRoute dies with it.

Feel free to unsubscribe anyway. It is harmless and never a bad practice.

user_54969730

I would rather unsubscribe all then control the exceptions. Seems easier to maintain.

Something like this

  ngOnInit() {
    this.subscriptions.push(
      this.activatedRoute.params.subscribe((params: Params) => {
        // do stuff
      }));

    this.subscriptions.push(
      this.activatedRoute.data.subscribe((data: any) => {
        // do stuff
      }));
  }

  ngOnDestroy() {
    this.subscriptions.forEach((subscription: Subscription) => {
      subscription.unsubscribe();
    });
  }

Please see the example here: https://stackblitz.com/edit/angular-unsubscribing-then-all?file=src/app/app.component.ts

user_19534310

For activated routes observable is an exception, because The ActivatedRoute and its observables are insulated from the Router itself. The Router destroys a routed component when it is no longer needed and the injected ActivatedRoute dies with it.

Source: Angular Doc

user_67368880

Normally when your component destroys, all the subscribed observables get unsubscribe automatically with few exceptions. But activatedRoute is not one of it. When router exit from a routed component it will destroy the component along with the injected activatedRoute

user_64286380
Related