Passing params into requests.Session.get raises TypeError

Viewed 9169

I am trying to understand why passing params into session.get raises TypeError in my example. response_get returns a 200 response, while response_open raises TypeError.

import requests


class Foo:

    def __init__(self):
        self.session = requests.Session()

    def get(self, url, params=None):
        """Return a Response object."""
        return requests.get(url, params)

    def open(self, url, params=None):
        """Return a Response object using the Session object."""
        return self.session.get(url, params)


if __name__ == '__main__':
    foo = Foo()
    response_get = foo.get('https://estilen.github.io')
    response_open = foo.open('https://estilen.github.io')

Error:

Traceback (most recent call last):
  File "/home/estilen/Dropbox/Python/leapy/foo.py", line 21, in <module>
    response_open = foo.open('https://estilen.github.io')
  File "/home/estilen/Dropbox/Python/leapy/foo.py", line 15, in open
    return self.session.get(url, params)
TypeError: get() takes 2 positional arguments but 3 were given
1 Answers

The thing is that get takes only one un-named (positional) argument:

def get(self, url, **kwargs):
    # ...

You are providing two: url and params.

To fix this, you need to provide params as a named (keyword) argument:

return self.session.get(url, params=params)
Related